[ci] introduce GitHub actions based private CI #2118
Conversation
|
Given this only runs on |
There was a problem hiding this comment.
This LGTM, but I worry slightly about the names of checks here becoming out of sync with the private repo. I think it would be difficult to factor those names out, though.
Doesn't the private CI create pending checks when it starts? Are these pending checks meant to fill the gap between those starting?
Could we instead have a job in this workflow that waits for the private CI to have started and we can block the merge queue on that?
|
The pending status will only be created when jobs are picked up, so if we have a busy CI pool then we'd be waiting for quite a while, wasting compute. |
The private CI works by using workflow dispatch to trigger a CI on another repository. Pending status checks are created before calling the dispatch to indicate their queued status before they are picked up in private CI, and also serves to block merge group from success. Signed-off-by: Gary Guo <[email protected]>
|
The new approach looks a lot cleaner, thanks a lot for working on that |
The private CI works by using workflow dispatch to trigger a CI on another repository.
Pending status checks are created before calling the dispatch to indicate their queued status before they are picked up in private CI, and also serves to block merge group from success.