Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Bench CMD for engines and replicas #965

Draft
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

shuo-wu
Copy link
Contributor

@shuo-wu shuo-wu commented Nov 29, 2023

@shuo-wu
Copy link
Contributor Author

shuo-wu commented Nov 30, 2023

Some problems in this PR:

  1. The seq-related bench may be meaningless. If multiple threads are enabled during a seq bench, seq means each thread is responsible for operating its chunk sequentially. But all threads issue IO requests simultaneously, is it actually a kind of rand IO? For example, when thread 1 operates offest 0 at this moment, thread 2 immediately takes the chance and operates offset 1MB before thread 1 tries to operate its next block (let's say offset 4096). This leads to a seq-IOPS-write benchmark result mismatching the fio result.
  2. The IOPS-read related benchmark result looks weird. In my test env (single node, 8 cores, 32G memory), when the thread count is 32, the engine seq/rand-IOPS-read would reach the max (82000), which is close to the local path performance (seq/rand result is 80000/91000). If we increase or decrease the thread count, 24 or 48 for example, the IOPS result is down to a half (43000).
  3. Not sure if libaio used by fio will lead to a difference between this cmd test result and the fio result

@shuo-wu shuo-wu force-pushed the bench branch 3 times, most recently from 984ee02 to 627d788 Compare December 4, 2023 04:03
Copy link

mergify bot commented Jan 3, 2024

This pull request is now in conflicts. Could you fix it @shuo-wu? 🙏

1 similar comment
Copy link

mergify bot commented Feb 7, 2024

This pull request is now in conflicts. Could you fix it @shuo-wu? 🙏

@shuo-wu shuo-wu force-pushed the bench branch 3 times, most recently from 1521e94 to 2102527 Compare April 26, 2024 18:58
Copy link

mergify bot commented Apr 27, 2024

This pull request is now in conflict. Could you fix it @shuo-wu? 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant