Fix changes to month dropdown #421
Conversation
When using the month dropdown option changes don’t take effect because moment(opt[type])[name](value) is passed a string. The momentJS docs state that this works when name===‘month’ but testing reveals that this isn’t the case. Always passing a Number instead of a String always works.
|
Nice find! Thanks, can you also provide a example of this problem using https://jsfiddle.net? |
|
Only happens with older versions of the MomentJS Library. Turns out it is fixed in 2.12 (moment/moment#2897) Anyway, here is a reproduction of the bug: https://jsfiddle.net/qty0hLho/24/ |
|
mmm, indeed, this was fixed in Moment.js |
|
I'm going to upgrade our codebase to the latest version of the momentJS and have my QA team perform a full regression of everywhere it is used. Especially as there were some other issues that I found in the dateRangePicker that I haven't had time to investigate fully when monthSelect is set to true. I'm hoping the upgrade will fix those, other wise I'll investigate further. Applying this fix to the library seems harmless enough as it bullet proofs it for people who are forced to use a legacy version of momentJS. That or update the library requirements to require 2.12+ instead of the current requirement of 2.8.1+. As we were already running 2.9 I knew we met the requirements. |
When using the month dropdown option changes don’t take effect because
moment(opt[type])name is passed a string. The momentJS docs
state that this works when name===‘month’ but testing reveals that this
isn’t the case. Always passing a Number instead of a String always
works.