MET-425 Create a common healthcheck plugin for public and private endpoints

[andrewi-wd]

Changes

This PR adds a new commonHealthcheckPlugin, which is registering two routes:

• A public one GET /
• A private one GET /health

Public route contain only resulting heartbeat from all provided healthchecks in a response. Extra info is also omitted.

Private route contain exactly the same response as publicHealthcheckPlugin has.

Checklist

• Apply one of following labels; major, minor, patch or skip-release
• I've updated the documentation, or no changes were necessary
• I've updated the tests, or no changes were necessary

[kibertoad]

mixing async/await and callbacks is often not the best idea, I would recommend to keep the original style of

          opts.healthChecks.map((healthcheck) => {
            return healthcheck.checker(app).then((result) => {
              if (result.error) {
                app.log.error(result.error, `${healthcheck.name} healthcheck has failed`)
              }
              return {
                name: healthcheck.name,
                result,
                isMandatory: healthcheck.isMandatory,
              }
            })
          }),

[andrewi-wd]

Reverted in 4306cba

[kibertoad]

@andrewi-wd should this be a breaking change (semver major)?

[andrewi-wd]

@andrewi-wd should this be a breaking change (semver major)?

@kibertoad I don't think so. I haven't modified existing healthcheck that is used, so there must be no problem with updates.