Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat(web-react): Introduce Card component #1535 #1757

Open
wants to merge 4 commits into
base: feat/web-card
Choose a base branch
from
Open

Feat(web-react): Introduce Card component #1535 #1757

wants to merge 4 commits into from

Conversation

pavelklibani
Copy link
Contributor

@pavelklibani pavelklibani commented Nov 19, 2024 •
edited
Loading

Description

Additional context

Issue reference

Component Card | web-react

@pavelklibani pavelklibani self-assigned this Nov 19, 2024
@github-actions github-actions bot added the feature New feature or request label Nov 19, 2024
@netlify Netlify
Copy link

netlify bot commented Nov 19, 2024 •
edited
Loading

✅ Deploy Preview for spirit-design-system ready!

Name Link
🔨 Latest commit 5872bdd
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system/deploys/674d7fa97bf2b4000810d4d1
😎 Deploy Preview https://deploy-preview-1757--spirit-design-system.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 96 (no change from production)
Accessibility: 91 (no change from production)
Best Practices: 100 (no change from production)
SEO: 91 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@pavelklibani pavelklibani changed the title Feat(web-react): Introduce Card component #1535 🚧 Feat(web-react): Introduce Card component #1535 Nov 19, 2024
@pavelklibani pavelklibani added the run-visual-tests Runs visual regression testing on this PR label Nov 19, 2024
@netlify Netlify
Copy link

netlify bot commented Nov 19, 2024 •
edited
Loading

✅ Deploy Preview for spirit-design-system-storybook ready!

Name Link
🔨 Latest commit 5872bdd
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-storybook/deploys/674d7fa92ba7cb0008951bd3
😎 Deploy Preview https://deploy-preview-1757--spirit-design-system-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions GitHub Actions
Copy link
Contributor

Here is the URL of the uploaded artifact: https://github.com/lmc-eu/spirit-design-system/actions/runs/11909824464/artifacts/2206228800

@pavelklibani pavelklibani force-pushed the feat/ds-1535-card-react branch 2 times, most recently from 81a587a to 86efae3 Compare November 19, 2024 14:33
@github-actions GitHub Actions
Copy link
Contributor

Here is the URL of the uploaded artifact: https://github.com/lmc-eu/spirit-design-system/actions/runs/11921067804/artifacts/2209688741

@github-actions GitHub Actions
Copy link
Contributor

Here is the URL of the uploaded artifact: https://github.com/lmc-eu/spirit-design-system/actions/runs/11930099184/artifacts/2212004765

@github-actions GitHub Actions
Copy link
Contributor

Here is the URL of the uploaded artifact: https://github.com/lmc-eu/spirit-design-system/actions/runs/11934677081/artifacts/2213266459

@github-actions GitHub Actions
Copy link
Contributor

Here is the URL of the uploaded artifact: https://github.com/lmc-eu/spirit-design-system/actions/runs/11936609885/artifacts/2213973836

@github-actions GitHub Actions
Copy link
Contributor

Here is the URL of the uploaded artifact: https://github.com/lmc-eu/spirit-design-system/actions/runs/11949666409/artifacts/2217557715

@github-actions GitHub Actions
Copy link
Contributor

Here is the URL of the uploaded artifact: https://github.com/lmc-eu/spirit-design-system/actions/runs/11950486579/artifacts/2217780766

@github-actions GitHub Actions
Copy link
Contributor

Here is the URL of the uploaded artifact: https://github.com/lmc-eu/spirit-design-system/actions/runs/11955180220/artifacts/2219129325

@github-actions GitHub Actions
Copy link
Contributor

Here is the URL of the uploaded artifact: https://github.com/lmc-eu/spirit-design-system/actions/runs/11955274559/artifacts/2219176054

crishpeen
crishpeen reviewed Nov 21, 2024
View reviewed changes
packages/web-react/src/components/Card/useCardStyleProps.ts Outdated Show resolved Hide resolved
packages/web-react/src/components/Card/useCardStyleProps.ts Outdated Show resolved Hide resolved
packages/web-react/src/components/Card/stories/CardTitle.stories.tsx Outdated Show resolved Hide resolved
packages/web-react/src/components/Card/stories/CardTitle.stories.tsx Outdated Show resolved Hide resolved
packages/web-react/src/components/Card/stories/CardTitle.stories.tsx Outdated Show resolved Hide resolved
packages/web-react/src/components/Card/demo/CardGeneralOptions.tsx Outdated Show resolved Hide resolved
packages/web-react/src/components/Card/Card.tsx Show resolved Hide resolved
packages/web-react/src/components/Card/CardLink.tsx Outdated Show resolved Hide resolved
packages/web-react/src/components/Card/README.md Show resolved Hide resolved
packages/web-react/src/components/Card/README.md Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link
Contributor

Here is the URL of the uploaded artifact: https://github.com/lmc-eu/spirit-design-system/actions/runs/11957086720/artifacts/2219774161

adamkudrna
adamkudrna reviewed Nov 25, 2024
View reviewed changes
Copy link
Contributor

@adamkudrna adamkudrna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! This is what I checked for now:

  • components' source
  • tests
  • README

packages/web-react/src/components/Card/index.ts Outdated Show resolved Hide resolved
packages/web-react/src/components/Card/CardLink.tsx Outdated Show resolved Hide resolved
packages/web-react/src/components/Card/README.md Show resolved Hide resolved
packages/web-react/src/components/Card/README.md Outdated Show resolved Hide resolved
packages/web-react/src/components/Card/README.md Outdated Show resolved Hide resolved
packages/web-react/src/components/Card/README.md Outdated Show resolved Hide resolved
packages/web-react/src/components/Card/README.md Show resolved Hide resolved
packages/web-react/src/components/Card/README.md Outdated Show resolved Hide resolved
packages/web-react/src/components/Card/README.md Outdated Show resolved Hide resolved
packages/web-react/src/components/Card/__tests__/CardEyebrows.test.tsx Outdated Show resolved Hide resolved
@pavelklibani pavelklibani marked this pull request as ready for review November 26, 2024 06:52
@github-actions GitHub Actions
Copy link
Contributor

Here is the URL of the uploaded artifact: https://github.com/lmc-eu/spirit-design-system/actions/runs/12025354423/artifacts/2237151149

@github-actions GitHub Actions
Copy link
Contributor

Here is the URL of the uploaded artifact: https://github.com/lmc-eu/spirit-design-system/actions/runs/12025478374/artifacts/2237185700

@github-actions GitHub Actions
Copy link
Contributor

Here is the URL of the uploaded artifact: https://github.com/lmc-eu/spirit-design-system/actions/runs/12025884444/artifacts/2237267060

@github-actions GitHub Actions
Copy link
Contributor

Here is the URL of the uploaded artifact: https://github.com/lmc-eu/spirit-design-system/actions/runs/12029435977/artifacts/2238308031

@github-actions GitHub Actions
Copy link
Contributor

Here is the URL of the uploaded artifact: https://github.com/lmc-eu/spirit-design-system/actions/runs/12030706042/artifacts/2238650178

crishpeen
crishpeen reviewed Nov 26, 2024
View reviewed changes
packages/web-react/src/components/Card/demo/CardCustom.tsx Outdated Show resolved Hide resolved
packages/web-react/src/types/card.ts Outdated Show resolved Hide resolved
packages/web-react/src/types/card.ts Outdated Show resolved Hide resolved
packages/web-react/src/components/Card/useCardStyleProps.ts Show resolved Hide resolved
packages/web-react/src/components/Card/useCardStyleProps.ts Show resolved Hide resolved
packages/web-react/src/components/Card/CardMedia.tsx Outdated Show resolved Hide resolved
packages/web-react/src/components/Card/README.md Outdated Show resolved Hide resolved
packages/web-react/src/components/Card/README.md Outdated Show resolved Hide resolved
packages/web-react/src/components/Card/README.md Outdated Show resolved Hide resolved
packages/web-react/src/components/Card/README.md Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link
Contributor

Here is the URL of the uploaded artifact: https://github.com/lmc-eu/spirit-design-system/actions/runs/12052480041/artifacts/2244962306

@github-actions GitHub Actions
Copy link
Contributor

Here is the URL of the uploaded artifact: https://github.com/lmc-eu/spirit-design-system/actions/runs/12066001307/artifacts/2248792689

@github-actions GitHub Actions
Copy link
Contributor

Here is the URL of the uploaded artifact: https://github.com/lmc-eu/spirit-design-system/actions/runs/12066401648/artifacts/2248901404

@github-actions GitHub Actions
Copy link
Contributor

Here is the URL of the uploaded artifact: https://github.com/lmc-eu/spirit-design-system/actions/runs/12066712184/artifacts/2248988499

@github-actions GitHub Actions
Copy link
Contributor

Here is the URL of the uploaded artifact: https://github.com/lmc-eu/spirit-design-system/actions/runs/12066984772/artifacts/2249056683

@github-actions GitHub Actions
Copy link
Contributor

Here is the URL of the uploaded artifact: https://github.com/lmc-eu/spirit-design-system/actions/runs/12071664143/artifacts/2250447829

@github-actions GitHub Actions
Copy link
Contributor

Here is the URL of the uploaded artifact: https://github.com/lmc-eu/spirit-design-system/actions/runs/12071974308/artifacts/2250542309

literat
literat reviewed Nov 29, 2024
View reviewed changes
packages/web-react/src/components/Card/__tests__/useCardStylePropsDataProvider.ts Outdated
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion (if-minor): Please, rename this to the CardStylePropsDataProvider and move it to /Card/__tests__/__fixtures__ directory. This is not a hook, IMHO.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 2, 2024

Here is the URL of the uploaded artifact: https://github.com/lmc-eu/spirit-design-system/actions/runs/12116529348/artifacts/2260503066

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@curdaj curdaj curdaj left review comments

@crishpeen crishpeen crishpeen left review comments

@adamkudrna adamkudrna adamkudrna left review comments

@literat literat literat left review comments

Assignees

@pavelklibani pavelklibani

Labels
feature New feature or request run-visual-tests Runs visual regression testing on this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@pavelklibani @literat @adamkudrna @crishpeen @curdaj