Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat(web): Introduce CorporateFooter component #1641

Draft
wants to merge 124 commits into
base: integration/BC-v3-design-tokens
Choose a base branch
from
Draft

Feat(web): Introduce CorporateFooter component #1641

wants to merge 124 commits into from

Conversation

adamkudrna
Copy link
Contributor

@adamkudrna adamkudrna commented Sep 12, 2024 •
edited
Loading

Description

Just a quick kick-off how the corporate footer could be built using Spirit components.

⚠️ NOT INTENDED TO BE MERGED AND DISTRIBUTED WITH THE PRODUCTION CODE.

TODO

  • Add correct web fonts for headline and claim.
  • Set the rest of headline and claim typography.
  • Make sure the inheritance from the rest of the page works as needed.
  • Make sure we are OK with slightly bigger links (14px instead of 13px).

@github-actions github-actions bot added the feature New feature or request label Sep 12, 2024
adamkudrna
adamkudrna commented Sep 12, 2024
View reviewed changes
packages/web/src/scss/components/CorporateFooter/_CorporateFooter.scss Outdated
Copy link
Contributor Author

@adamkudrna adamkudrna Sep 12, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merge blocker: ⚠️ NOT INTENDED TO BE MERGED AND DISTRIBUTED WITH THE PRODUCTION CODE.

@netlify Netlify
Copy link

netlify bot commented Sep 12, 2024 •
edited
Loading

❌ Deploy Preview for spirit-design-system failed. Why did it fail? →

Name Link
🔨 Latest commit e9fa96c
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system/deploys/673cdfa0804b4b0007856146

@netlify Netlify
Copy link

netlify bot commented Sep 12, 2024 •
edited
Loading

❌ Deploy Preview for spirit-design-system-storybook failed. Why did it fail? →

Name Link
🔨 Latest commit e9fa96c
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-storybook/deploys/673cdfa0d96c2b0008b18def

@coveralls
Copy link

Coverage Status

coverage: 66.205% (-13.2%) from 79.421%
when pulling 7267e96 on feature/corporate-footer
into 2c04230 on integration/BC-v3-design-tokens.

@coveralls
Copy link

coveralls commented Sep 12, 2024 •
edited
Loading

Coverage Status

coverage: 78.69%. remained the same
when pulling 37c4314 on feature/corporate-footer
into d2d3f54 on integration/BC-v3-design-tokens.

@crishpeen crishpeen force-pushed the integration/BC-v3-design-tokens branch 7 times, most recently from 7e531b9 to 7c9caf7 Compare September 19, 2024 15:48
@literat literat mentioned this pull request Sep 23, 2024
Merged
@crishpeen crishpeen force-pushed the integration/BC-v3-design-tokens branch from 60a10d7 to 429c9e1 Compare October 1, 2024 11:27
@adamkudrna adamkudrna force-pushed the integration/BC-v3-design-tokens branch from 429c9e1 to ec062d6 Compare October 1, 2024 11:34
@crishpeen crishpeen force-pushed the integration/BC-v3-design-tokens branch 2 times, most recently from 65ae9e3 to 852b0e6 Compare October 8, 2024 09:36
@literat literat force-pushed the integration/BC-v3-design-tokens branch 4 times, most recently from 912c9b2 to f5ad8a7 Compare October 17, 2024 14:17
@crishpeen crishpeen force-pushed the integration/BC-v3-design-tokens branch from fa33a68 to bab5113 Compare November 5, 2024 12:47
@crishpeen crishpeen force-pushed the integration/BC-v3-design-tokens branch from c1a59e5 to cf52609 Compare November 12, 2024 14:49
crishpeen and others added 25 commits November 19, 2024 19:48
@crishpeen
Feat(web-twig): Remove spirit- prefix from themes
a6cfe02
@curdaj @crishpeen
BREAKING CHANGE(web-react): Add the option to allow visited state in …
e8e42e8 
…Link #DS-1501
@curdaj @crishpeen
BREAKING CHANGE(web): Add the option to allow visited state in Link #…
11bd80c 
…DS-1501
@curdaj @crishpeen
BREAKING CHANGE(web-twig): Add the option to allow visited state in L…
da6d6a7 
…ink #DS-1501
@curdaj @crishpeen
Docs: Add the option to allow visited state in Link #DS-1501
55ddd40
@curdaj @crishpeen
Feat(codemods): Add the option to allow visited state in Link #DS-1501
5f81265
@crishpeen
Feat(codemods): Introduce ToastBar color inverted to neutral codemod
25f0313
@crishpeen
Docs(web-react): Introduce Migration Guide to version 3
4c61af1
@crishpeen
Docs(web-twig): Introduce Migration Guide to version 4
2e50891
@adamkudrna @crishpeen
Docs(web): Document usage of the updated design tokens and themes #DS…
b79650c 
…-1489
@adamkudrna @crishpeen
Refactor(web): Unify generation of responsive spacing and alignment i…
993389d 
…n layout components #DS-1423

In `Flex`, `Grid`, and `Stack` components:

- responsive spacing is now generated exclusively with the spacing tools,
- responsive alignment is now generated exclusively with the dictionary tools.
@curdaj @crishpeen
Feat(web-react): Add spacingX and spacingY to Flex #DS-1427
aeba804
@curdaj @crishpeen
BREAKING CHANGE(web): Replace spacing with spacing-x and spacing-y pr…
ef652bf 
…operty in Flex #DS-1427
@curdaj @crishpeen
Docs(web): Replace spacing with spacing-x and spacing-y property in F…
d6efd11 
…lex #DS-1427
@adamkudrna @crishpeen
Refactor(web): Abstract spacing tools to generate any custom properti…
26ada6c 
…es cascade #DS-1546
@curdaj @crishpeen
Fix(web-react): Unsupported export in client boundary #DS-1549
3cd95fc
@curdaj @crishpeen
Fix(web-react): Unwanted Link hasVisitedStyleAllowed prop on a DOM el…
fe58cb5 
…ement #DS-1553
@curdaj @crishpeen
Fix(web-react): Unwanted Heading elementType prop on a DOM element #D…
dcc03a0 
…S-1553
@pavelklibani @crishpeen
BREAKING CHANGE(web): Wrap list with validation text
82a0df6 
- Wrap list with div and move class from list to div
- Reset css for this list

- Solves #DS-1255
@pavelklibani @crishpeen
Refactor(form-validations): Update form validations error lists
75eb42d 
- Multiple errors are now displayed in a list
@pavelklibani @crishpeen
Refactor(web-twig): Wrap ValidationText list in div
d78221f
@pavelklibani @crishpeen
Refactor(web-react): Wrap ValidationText list in div and dynamical role
db257cc 
- List of errors is now wrapped in a div
- `role="alert"`` is now dynamically added when list changes
@crishpeen
Feat(web): Introduce Plain Button #DS-1454
fe416c6
@crishpeen
Feat(web-react): Introduce Plain Button #DS-1454
4cb9ee3
@crishpeen
Feat(web-twig): Introduce Plain Button #DS-1454
271af54
@crishpeen crishpeen force-pushed the integration/BC-v3-design-tokens branch from 3a41dee to 271af54 Compare November 19, 2024 18:50
@literat literat force-pushed the integration/BC-v3-design-tokens branch from e6acc7f to 45fe689 Compare November 22, 2024 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OndraM OndraM Awaiting requested review from OndraM

@literat literat Awaiting requested review from literat literat will be requested when the pull request is marked ready for review literat is a code owner

@crishpeen crishpeen Awaiting requested review from crishpeen crishpeen will be requested when the pull request is marked ready for review crishpeen is a code owner

@pavelklibani pavelklibani Awaiting requested review from pavelklibani pavelklibani will be requested when the pull request is marked ready for review pavelklibani is a code owner

@curdaj curdaj Awaiting requested review from curdaj curdaj will be requested when the pull request is marked ready for review curdaj is a code owner

Assignees

@adamkudrna adamkudrna

Labels
feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@adamkudrna @coveralls @crishpeen @pavelklibani @curdaj @literat