Docs(web-twig): Demonstrate composition of `Header` with `Dropdown` #1048

adamkudrna · 2023-09-07T16:47:07Z

Description

Demonstrate the composition of Header and Dropdown.

Additional context

Issue reference

N/A

netlify · 2023-09-07T16:48:03Z

✅ Deploy Preview for spirit-design-system-storybook canceled.

Name	Link
🔨 Latest commit	`ba53f06`
🔍 Latest deploy log	https://app.netlify.com/sites/spirit-design-system-storybook/deploys/667a93b32783f0000859e93f

netlify · 2023-09-07T16:48:04Z

✅ Deploy Preview for spirit-design-system-demo canceled.

Name	Link
🔨 Latest commit	`da1e1f8`
🔍 Latest deploy log	https://app.netlify.com/sites/spirit-design-system-demo/deploys/654cca438fe36600086338d7

netlify · 2023-09-07T16:48:40Z

✅ Deploy Preview for spirit-design-system-react ready!

Name	Link
🔨 Latest commit	`da1e1f8`
🔍 Latest deploy log	https://app.netlify.com/sites/spirit-design-system-react/deploys/654cca43f5fab400084fd90b
😎 Deploy Preview	https://deploy-preview-1048--spirit-design-system-react.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify · 2023-09-07T16:49:40Z

✅ Deploy Preview for spirit-design-system-validations canceled.

Name	Link
🔨 Latest commit	`da1e1f8`
🔍 Latest deploy log	https://app.netlify.com/sites/spirit-design-system-validations/deploys/654cca436125b70008554b24

github-actions · 2023-09-07T16:53:08Z

coverage: 69.502% (-27.0%) from 96.46% when pulling 03d27f1 on docs/header-with-dropdown into 53fc021 on main.

...s/web-twig/src/Resources/components/Header/stories/HeaderInvertedWithActionsAndDropdown.twig

literat · 2023-09-08T14:03:43Z

👏 Great. But consider usage of the button instead of the link for dropdown trigger :-)

...s/web-twig/src/Resources/components/Header/stories/HeaderInvertedWithActionsAndDropdown.twig

dlouhak · 2023-09-11T10:30:05Z

...s/web-twig/src/Resources/components/Header/stories/HeaderInvertedWithActionsAndDropdown.twig

+
+    <HeaderDesktopActions color="secondary">
+        <HeaderNav>
+            <HeaderNavItem UNSAFE_style="position: relative;">


Maybe a foolish idea, but what about to apply display: contents; to the DropdownWrapper?
Then we could also use this component in the cases like this.

I'm sorry, it's not true. It would affect the Dropdown menu. 🙈
But hypothetically flex… 👀

display: contents would make DropdownWrapper disappear from DOM which would lead to a misplaced Dropdown…

Originally, I was even considering rather a helper class like position-relative because that's the only thing I want it to do. Anything else could potentially cause more harm than good, I think.

There is a high chance that with Breeze version we are able to solve this case without additional styles – @adamkudrna will take a look at it if there will be a task in sprint. 🙌🏻

crishpeen

LGTM, please fix the already mentioned problems.

Also please add this demo to the React and Web packages.

coveralls · 2023-09-21T12:33:19Z

Changes unknown
when pulling ba53f06 on docs/header-with-dropdown
into ** on main**.

nx-cloud · 2023-11-09T12:04:00Z

☁️ Nx Cloud Report

CI is running/has finished running commands for commit da1e1f8. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 3 targets

Sent with 💌 from NxCloud.

literat

LGTM 👍

…down`

…h `Dropdown`

netlify · 2024-06-25T09:53:28Z

✅ Deploy Preview for spirit-design-system ready!

Name	Link
🔨 Latest commit	`ba53f06`
🔍 Latest deploy log	https://app.netlify.com/sites/spirit-design-system/deploys/667a93b395ba0a00086127a4
😎 Deploy Preview	https://deploy-preview-1048--spirit-design-system.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	1 paths audited Performance: 96 (no change from production) Accessibility: 93 (no change from production) Best Practices: 100 (no change from production) SEO: 82 (no change from production) PWA: - View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

nx-cloud · 2024-06-25T09:56:36Z

☁️ Nx Cloud Report

CI is running/has finished running commands for commit ba53f06. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 3 targets

Sent with 💌 from NxCloud.

adamkudrna requested a review from dlouhak September 7, 2023 16:47

adamkudrna requested review from literat, crishpeen, pavelklibani and a team as code owners September 7, 2023 16:47

adamkudrna self-assigned this Sep 7, 2023

github-actions bot added the documentation Improvements or additions to documentation label Sep 7, 2023

literat reviewed Sep 8, 2023

View reviewed changes

...s/web-twig/src/Resources/components/Header/stories/HeaderInvertedWithActionsAndDropdown.twig Outdated Show resolved Hide resolved

dlouhak reviewed Sep 11, 2023

View reviewed changes

...s/web-twig/src/Resources/components/Header/stories/HeaderInvertedWithActionsAndDropdown.twig Outdated Show resolved Hide resolved

dlouhak reviewed Sep 11, 2023

View reviewed changes

...s/web-twig/src/Resources/components/Header/stories/HeaderInvertedWithActionsAndDropdown.twig Outdated Show resolved Hide resolved

dlouhak reviewed Sep 11, 2023

View reviewed changes

crishpeen reviewed Sep 21, 2023

View reviewed changes

adamkudrna force-pushed the docs/header-with-dropdown branch from 03d27f1 to 8aaf900 Compare September 21, 2023 12:29

adamkudrna force-pushed the docs/header-with-dropdown branch from 8aaf900 to d4c3c47 Compare September 26, 2023 10:55

adamkudrna requested review from dlouhak, literat and crishpeen September 26, 2023 10:55

adamkudrna force-pushed the docs/header-with-dropdown branch from d4c3c47 to da1e1f8 Compare November 9, 2023 12:02

literat approved these changes Nov 10, 2023

View reviewed changes

adamkudrna added 2 commits June 25, 2024 11:06

Docs(web-twig): Demonstrate composition of Header with Dropdown

ddbc332

fixup! Docs(web-twig): Demonstrate composition of Header with `Drop…

e091e73

…down`

adamkudrna requested a review from curdaj as a code owner June 25, 2024 09:53

fixup! fixup! Docs(web-twig): Demonstrate composition of Header wit…

ba53f06

…h `Dropdown`

adamkudrna force-pushed the docs/header-with-dropdown branch from d952b0f to ba53f06 Compare June 25, 2024 09:53

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Docs(web-twig): Demonstrate composition of `Header` with `Dropdown` #1048

Docs(web-twig): Demonstrate composition of `Header` with `Dropdown` #1048

adamkudrna commented Sep 7, 2023

netlify bot commented Sep 7, 2023 •

edited

Loading

netlify bot commented Sep 7, 2023 •

edited

Loading

netlify bot commented Sep 7, 2023 •

edited

Loading

netlify bot commented Sep 7, 2023 •

edited

Loading

github-actions bot commented Sep 7, 2023

literat commented Sep 8, 2023

dlouhak Sep 11, 2023

dlouhak Sep 11, 2023 •

edited

Loading

adamkudrna Sep 26, 2023

dlouhak Jun 27, 2024

crishpeen left a comment

coveralls commented Sep 21, 2023 •

edited

Loading

nx-cloud bot commented Nov 9, 2023 •

edited

Loading

literat left a comment

netlify bot commented Jun 25, 2024 •

edited

Loading

nx-cloud bot commented Jun 25, 2024 •

edited

Loading

Docs(web-twig): Demonstrate composition of Header with Dropdown #1048

Are you sure you want to change the base?

Docs(web-twig): Demonstrate composition of Header with Dropdown #1048

Conversation

adamkudrna commented Sep 7, 2023

Description

Additional context

Issue reference

netlify bot commented Sep 7, 2023 • edited Loading

✅ Deploy Preview for spirit-design-system-storybook canceled.

netlify bot commented Sep 7, 2023 • edited Loading

✅ Deploy Preview for spirit-design-system-demo canceled.

netlify bot commented Sep 7, 2023 • edited Loading

✅ Deploy Preview for spirit-design-system-react ready!

netlify bot commented Sep 7, 2023 • edited Loading

✅ Deploy Preview for spirit-design-system-validations canceled.

github-actions bot commented Sep 7, 2023

literat commented Sep 8, 2023

dlouhak Sep 11, 2023

Choose a reason for hiding this comment

dlouhak Sep 11, 2023 • edited Loading

Choose a reason for hiding this comment

adamkudrna Sep 26, 2023

Choose a reason for hiding this comment

dlouhak Jun 27, 2024

Choose a reason for hiding this comment

crishpeen left a comment

Choose a reason for hiding this comment

coveralls commented Sep 21, 2023 • edited Loading

nx-cloud bot commented Nov 9, 2023 • edited Loading

☁️ Nx Cloud Report

literat left a comment

Choose a reason for hiding this comment

netlify bot commented Jun 25, 2024 • edited Loading

✅ Deploy Preview for spirit-design-system ready!

nx-cloud bot commented Jun 25, 2024 • edited Loading

☁️ Nx Cloud Report

Docs(web-twig): Demonstrate composition of `Header` with `Dropdown` #1048

Docs(web-twig): Demonstrate composition of `Header` with `Dropdown` #1048

netlify bot commented Sep 7, 2023 •

edited

Loading

netlify bot commented Sep 7, 2023 •

edited

Loading

netlify bot commented Sep 7, 2023 •

edited

Loading

netlify bot commented Sep 7, 2023 •

edited

Loading

dlouhak Sep 11, 2023 •

edited

Loading

coveralls commented Sep 21, 2023 •

edited

Loading

nx-cloud bot commented Nov 9, 2023 •

edited

Loading

netlify bot commented Jun 25, 2024 •

edited

Loading

nx-cloud bot commented Jun 25, 2024 •

edited

Loading