[Driver] Pass --cuda-path to test
#117415
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
llvmbot
added
clang
|
@llvm/pr-subscribers-clang @llvm/pr-subscribers-clang-driver Author: Kai Luo (bzEq) ChangesMy local build, on Debian GNU/Linux 12 (bookworm), complains Fix it by passing Full diff: https://github.com/llvm/llvm-project/pull/117415.diff 1 Files Affected:
diff --git a/clang/test/Driver/cuda-no-threadsafe-statics.cu b/clang/test/Driver/cuda-no-threadsafe-statics.cu
index eb15312f8f7d14..494f0e7a89ff32 100644
--- a/clang/test/Driver/cuda-no-threadsafe-statics.cu
+++ b/clang/test/Driver/cuda-no-threadsafe-statics.cu
@@ -2,7 +2,7 @@
// compilation only.
//
// RUN: %clang -### -x cuda --target=x86_64-linux-gnu -c --cuda-gpu-arch=sm_20 %s \
-// RUN: -nocudainc -nocudalib 2>&1 | FileCheck %s
+// RUN: -nocudainc -nocudalib --no-cuda-version-check 2>&1 | FileCheck %s
// RUN: %clang -### -x hip --target=x86_64-linux-gnu -c --cuda-gpu-arch=gfx1010 %s \
// RUN: -nocudainc -nocudalib 2>&1 | FileCheck %s
|
|
I am surprised that this is needed. I suspect clang picks the default CUDA version on your machine. While A better way to fix this may be to pass |
My local build, on Debian GNU/Linux 12 (bookworm), complains ``` clang: error: GPU arch sm_20 is supported by CUDA versions between 7.0 and 8.0 (inclusive), but installation at /usr/lib/cuda is 11.8; use '--cuda-path' to specify a different CUDA install, pass a different GPU arch with '--cuda-gpu-arch', or pass '--no-cuda-version-check' ``` Fix it by passing `--no-cuda-version-check`.
bzEq
force-pushed
the
no-cuda-version-check
branch
from
eb0bc0b
to
253a669
Compare
|
Address comment. |
Artem-B
approved these changes
Nov 25, 2024
bzEq
changed the title
--no-cuda-version-check to test--cuda-path to test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My local build, on Debian GNU/Linux 12 (bookworm), complains
Fix it by passing
--cuda-path. Hope this doesn't affect the original intention of the test.