Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ROCDL] Use attached target on the GPU module when lowering GPU ops to ROCDL #110735

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
+70 −25

Address review comments from fabian and update error strings in the t…

4c18e8a
Select commit
Loading
Failed to load commit list.
Open

[ROCDL] Use attached target on the GPU module when lowering GPU ops to ROCDL #110735

Address review comments from fabian and update error strings in the t…
4c18e8a
Select commit
Loading
Failed to load commit list.
Graphite App / Graphite / ai_reviewer check succeeded Oct 4, 2024 in 0s

Graphite AI review summary

This change modifies the GPU to ROCDL conversion pass to infer the target chipset from the GPU module's attributes instead of using a default value. It also updates related test files to accommodate this change.

Left no comments. Looks good to me!

Details

View more details on Graphite App