[libc++] Add a Github action to build libc++'s Docker images

[ldionne]

This patch adds a Github action that runs whenever changes to the libc++ Docker images are pushed to main. The action will rebuild the Docker images and push them to LLVM's container registry so that we can then point to those images from our CI nodes.

[llvmbot]

@llvm/pr-subscribers-github-workflow

Author: Louis Dionne (ldionne)

Changes

This patch adds a Github action that runs whenever changes to the libc++ Docker images are pushed to main. The action will rebuild the Docker images and push them to LLVM's container registry so that we can then point to those images from our CI nodes.

---

Full diff: https://github.com/llvm/llvm-project/pull/110020.diff

1 Files Affected:

• (added) .github/workflows/libcxx-build-containers.yaml (+51)

diff --git a/.github/workflows/libcxx-build-containers.yaml b/.github/workflows/libcxx-build-containers.yaml
new file mode 100644
index 00000000000000..e4ff2141f1357e
--- /dev/null
+++ b/.github/workflows/libcxx-build-containers.yaml
@@ -0,0 +1,51 @@
+# This file defines an action that builds the various Docker images used to run
+# libc++ CI whenever modifications to those Docker files are pushed to `main`.
+#
+# The images are pushed to the LLVM package registry at https://github.com/orgs/llvm/packages
+# and tagged appropriately. The selection of which Docker image version is used by the libc++
+# CI nodes at any given point is controlled by the libc++ maintainers using a mechanism that
+# is not publicly visible for safety purposes.
+
+name: Build Docker images for libc++ CI
+
+permissions:
+  contents: read
+  packages: write
+
+on:
+  push:
+    branches:
+      - main
+    paths:
+      - 'libcxx/utils/ci/**'
+
+jobs:
+  build-and-push:
+    runs-on: ubuntu-latest
+    if: github.repository_owner == 'llvm'
+
+    steps:
+    - uses: actions/checkout@v4
+
+    - name: Log in to GitHub Container Registry
+      uses: docker/login-action@v3
+      with:
+        registry: ghcr.io
+        username: ${{ github.actor }}
+        password: ${{ secrets.GITHUB_TOKEN }}
+
+    - name: Build and push the Linux builder image
+      working-directory: libcxx/utils/ci
+      run:
+        - docker compose build actions-builder
+        - docker compose push actions-builder
+      env:
+        TAG: libcxx-linux-builder:${{ github.sha }}
+
+    - name: Build and push the Android builder image
+      working-directory: libcxx/utils/ci
+      run:
+        - docker compose build android-buildkite-builder
+        - docker compose push android-buildkite-builder
+      env:
+        TAG: libcxx-android-builder:${{ github.sha }}

[llvmbot]

@llvm/pr-subscribers-libcxx

Author: Louis Dionne (ldionne)

Changes

This patch adds a Github action that runs whenever changes to the libc++ Docker images are pushed to main. The action will rebuild the Docker images and push them to LLVM's container registry so that we can then point to those images from our CI nodes.

---

Full diff: https://github.com/llvm/llvm-project/pull/110020.diff

1 Files Affected:

• (added) .github/workflows/libcxx-build-containers.yaml (+51)

diff --git a/.github/workflows/libcxx-build-containers.yaml b/.github/workflows/libcxx-build-containers.yaml
new file mode 100644
index 00000000000000..e4ff2141f1357e
--- /dev/null
+++ b/.github/workflows/libcxx-build-containers.yaml
@@ -0,0 +1,51 @@
+# This file defines an action that builds the various Docker images used to run
+# libc++ CI whenever modifications to those Docker files are pushed to `main`.
+#
+# The images are pushed to the LLVM package registry at https://github.com/orgs/llvm/packages
+# and tagged appropriately. The selection of which Docker image version is used by the libc++
+# CI nodes at any given point is controlled by the libc++ maintainers using a mechanism that
+# is not publicly visible for safety purposes.
+
+name: Build Docker images for libc++ CI
+
+permissions:
+  contents: read
+  packages: write
+
+on:
+  push:
+    branches:
+      - main
+    paths:
+      - 'libcxx/utils/ci/**'
+
+jobs:
+  build-and-push:
+    runs-on: ubuntu-latest
+    if: github.repository_owner == 'llvm'
+
+    steps:
+    - uses: actions/checkout@v4
+
+    - name: Log in to GitHub Container Registry
+      uses: docker/login-action@v3
+      with:
+        registry: ghcr.io
+        username: ${{ github.actor }}
+        password: ${{ secrets.GITHUB_TOKEN }}
+
+    - name: Build and push the Linux builder image
+      working-directory: libcxx/utils/ci
+      run:
+        - docker compose build actions-builder
+        - docker compose push actions-builder
+      env:
+        TAG: libcxx-linux-builder:${{ github.sha }}
+
+    - name: Build and push the Android builder image
+      working-directory: libcxx/utils/ci
+      run:
+        - docker compose build android-buildkite-builder
+        - docker compose push android-buildkite-builder
+      env:
+        TAG: libcxx-android-builder:${{ github.sha }}

[tstellar]

This looks good to me.

[ldionne]

@tstellar Do you know how I could test this? How did you test .github/workflows/build-ci-container.yml when you first came up with it?

[boomanaiden154]

Do you know how I could test this? How did you test .github/workflows/build-ci-container.yml when you first came up with it?

We added a pull_request event to it and then conditioned the actual upload on being a push event. So it builds the container and runs through everything in a pull request modifying it, but only actually uploads and deploys when it gets pushed into main.

[EricWF]

Can we move the login after the build, that way we can't capture the docker credentials inside the build?

[EricWF]

LGTM after the slight change regarding the credentials.