Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VerifToSMT] Only update registers on clock posedge #7878

Merged
merged 3 commits into from
Nov 25, 2024

Conversation

TaoBi22
Copy link
Contributor

@TaoBi22 TaoBi22 commented Nov 22, 2024

Fixes a bug in VerifToSMT where register states are updated on each timestep, rather than only on clock posedges. This requires locking the pass down to single-clock BMC ops for now, until we're able to associate register inputs/outputs with specific clocks.

@TaoBi22 TaoBi22 added the bug Something isn't working label Nov 22, 2024
@TaoBi22 TaoBi22 added the SMT label Nov 22, 2024
Copy link
Member

@maerhart maerhart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this!

lib/Conversion/VerifToSMT/VerifToSMT.cpp Outdated Show resolved Hide resolved
lib/Conversion/VerifToSMT/VerifToSMT.cpp Outdated Show resolved Hide resolved
test/Conversion/VerifToSMT/verif-to-smt.mlir Outdated Show resolved Hide resolved
@TaoBi22 TaoBi22 merged commit c690c9d into llvm:main Nov 25, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working SMT
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants