Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Weather, add padding and padding defaults to custom overrides, add more override tags #6520

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

Weather, add padding and padding defaults to custom overrides, add more override tags #6520

wants to merge 10 commits into from

Conversation

aperkins81
Copy link
Contributor

@Gr3q Continuation from #6455

Please let me know if you see anything else, cheers :)

@aperkins81
Copy link
Contributor Author

aperkins81 commented Oct 22, 2024 •
edited
Loading

I tried a few different combinations from the readme and am now thinking of removing padding defaults (but still keeping functionality for defaults) and letting users specify their padding preferences, what do you think? (have had a few drinks so ignore this if you're happy with defaults, or feel free to change them)

@aperkins81
Copy link
Contributor Author

OK stepping away from the weather applet for now, let me know if you need any changes, cheers

@rcalixte rcalixte marked this pull request as draft October 23, 2024 03:55
Gr3q
Gr3q approved these changes Oct 23, 2024
View reviewed changes
Copy link
Contributor

@Gr3q Gr3q left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm OK with the code, I think the screenshot doesn't really convey what you want - being 2 panels stacked on top of each other probably will confuse most people.

But I can let it pass.

@Gr3q Gr3q mentioned this pull request Oct 23, 2024
Open
@aperkins81
Copy link
Contributor Author

@Gr3q Original screenshot added to avoid confusion. Cheers

@aperkins81 aperkins81 marked this pull request as ready for review November 6, 2024 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gr3q Gr3q Gr3q approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aperkins81 @Gr3q