All Intel CPU based boards: tweak cpufreq=xen:hwp related settings in an attempt to fix xen related powersave/imstability issues (enabled by default under QubesOS) #1693
Conversation
…xen related powersave issues that is not enabled by default under QubesOS
Added by:
sed -i 's/\(export CONFIG_BOOT_KERNEL_ADD="\)\(.*\)\("\)/\1\2cpufreq=xen:hwp\3/' boards/*/*.config
And then reverting change manually on kgpe-d16 and Talos II
Signed-off-by: Thierry Laurion <[email protected]>
tlaurion
changed the title
There was a problem hiding this comment.
@tlaurion Thanks for finding this.
Does it negatively impact non-Xen distributions?
For Qubes, it's not specifically related to Heads is it? I'm on the fence here because users/vendors could also enable it by adding it to grub.cfg. If there's any downside, we're preventing the user from changing it if we enable it in Heads, it is not easy to override CONFIG_BOOT_KERNEL_ADD. (Somebody on the thread said typing input was noticeably slower, haven't tested it myself yet.)
| @@ -32,7 +32,7 @@ export CONFIG_TPM=y | |||
| export CONFIG_BOOTSCRIPT=/bin/gui-init | |||
| export CONFIG_BOOT_REQ_HASH=n | |||
| export CONFIG_BOOT_REQ_ROLLBACK=n | |||
| export CONFIG_BOOT_KERNEL_ADD="intel_iommu=on" | |||
| export CONFIG_BOOT_KERNEL_ADD="intel_iommu=oncpufreq=xen:hwp" | |||
There was a problem hiding this comment.
This needs a space assuming we go ahead with the change (thoughts in review summary)
| @@ -89,7 +89,7 @@ export CONFIG_BOOTSCRIPT=/bin/gui-init | |||
| export CONFIG_BOOT_REQ_HASH=n | |||
| export CONFIG_BOOT_REQ_ROLLBACK=n | |||
| export CONFIG_BOOT_RECOVERY_SERIAL="/dev/ttyS0" | |||
| export CONFIG_BOOT_KERNEL_ADD="console=ttyS0 console=tty systemd.zram=0" | |||
| export CONFIG_BOOT_KERNEL_ADD="console=ttyS0 console=tty systemd.zram=0cpufreq=xen:hwp" | |||
There was a problem hiding this comment.
This doesn't apply to qemu boards does it? (If so it would need a space though.)
|
Actually, @JonathonHall-Purism let's remember that anything added under KERNEL_ADD will passthrough init if not kernel related and then initramfs of OSes need to take it into consideration to apply it or else dismiss it. Therefore, this would impact Xen based distributions only, which for today is only QubesOS. Other OSes would not be impacted, just as we saw in past PR when some parameters reached init and then normally init will tell that some parameters were not applied before dismissing them. |
tlaurion
changed the title
WiP
Related to enforcing suggestions under QubesOS/qubes-issues#4604
Preliminary testing
doubled nv41 battery on basic usage from under 2h of battery to more then 4h under basic browsing without anything else then adding this parameter to KERNEL_ADDedit: must have changed something else TLP related at the same time because it is enabled by défaut as confirmed by Marek at https://matrix.to/#/!pAlHOfxQNPXOgFGTmo:matrix.org/$D9aZXzGq4SWLD4wQ_PlLpFwVr7BgsWQvyR-TtLECg34?via=matrix.org&via=nitro.chat&via=envs.netSorry for the noise.