test: fix some Ansible warnings not caught by lint #704
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #704 +/- ##
===========================================
+ Coverage 20.50% 43.22% +22.72%
===========================================
Files 10 12 +2
Lines 1478 3100 +1622
Branches 433 0 -433
===========================================
+ Hits 303 1340 +1037
- Misses 1174 1760 +586
+ Partials 1 0 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
[citest] |
1 similar comment
|
[citest] |
spetrosi
previously approved these changes
Jul 24, 2024
richm
force-pushed
the
fix-templating-warnings
branch
from
5bd5daa
to
6bc4100
Compare
liangwen12year
approved these changes
Jul 24, 2024
Do not use templating in `when:`, `that:`, `until:`. These are evaluated as Jinja statements. In cases where the string used is long or awkward to generate in-line, use an intermediate var for the value. Use a unique loop var instead of `item` in cases where a loop may be called in a nested context. Fix some formatting. Signed-off-by: Rich Megginson <[email protected]>
richm
force-pushed
the
fix-templating-warnings
branch
from
6bc4100
to
464fa35
Compare
|
[citest] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not use templating in
when:,that:,until:. Theseare evaluated as Jinja statements. In cases where the string
used is long or awkward to generate in-line, use an
intermediate var for the value.
Use a unique loop var instead of
itemin cases where a loopmay be called in a nested context.
Fix some formatting.
Signed-off-by: Rich Megginson [email protected]