Fix and rework canbusload #556
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The CAN interface description can now have two bitrates. Extend the length check to handle the CAN FD data bitrate correctly. Fixes: 6382765 ("canbusload: count databitrate seperately") Signed-off-by: Oliver Hartkopp <[email protected]>
Rework to use a single CAN socket for the received CAN traffic. This allows to shutdown and restart various CAN interfaces without terminating the application. Additionally an auto detection has been implemented with the 'any' CAN interface. E.g. with any@500000,2000000 CAN interfaces that have not been defined before are assigned with the given 'any' bitrates when a CAN frame from this CAN interface has been received. Signed-off-by: Oliver Hartkopp <[email protected]>
To access msg_flags for RX/TX direction detection. Signed-off-by: Oliver Hartkopp <[email protected]>
Signed-off-by: Oliver Hartkopp <[email protected]>
With the introduction of CAN FD the bitrate has not been printed correcty. Fix the CAN FD bitrate output and try to shrink the bitrates by using kilo or Mega suffixes: 500000 -> 500k Fixes: 6382765 ("canbusload: count databitrate seperately") Signed-off-by: Oliver Hartkopp <[email protected]>
marckleinebudde
requested changes
Aug 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rework to use a single CAN socket for the received CAN traffic.
This allows to shutdown and restart various CAN interfaces without
terminating the application.
Additionally an auto detection has been implemented with the 'any' CAN
interface. E.g. with any@500000,2000000 CAN interfaces that have not
been defined before are assigned with the given 'any' bitrates when a
CAN frame from this CAN interface has been received.
show RX/TX direction in bargraph
fix and improve the bitrate output