Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typography corrections #318

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Typography corrections #318

wants to merge 2 commits into from

Conversation

codam
Copy link

@codam codam commented Jun 1, 2019

Good job guys!

@codam
Typography corrections
300321d 
Good job guys!
megoth
megoth requested changes Jun 6, 2019
View reviewed changes
Copy link
Collaborator

@megoth megoth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A slight change needed, but apart from that good - thanks for doing this kinds of PRs ^_^

Documentation/webapp-intro.html Outdated
@@ -64,7 +64,7 @@ <h3>Glossary of Terms</h3>

<h3>Setting up a Store</h3>

<p>Suppose we have a store, and we set up a person and their profile. Their webid is the URI '<a href="https://example.com/alice/card#me">https://example.com/alice/card#me</a>', which is, if you like, a local variable ‘me’ within the the file '<a href="https://example.com/alice/card">https://example.com/alice/card</a>'. </p>
<p>Suppose we have a store, and we set up a person and their profile. Their web id is the URI '<a href="https://example.com/alice/card#me">https://example.com/alice/card#me</a>', which is, if you like, a local variable ‘me’ within the the file '<a href="https://example.com/alice/card">https://example.com/alice/card</a>'. </p>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should be WebID

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!

megoth
megoth approved these changes Jun 7, 2019
View reviewed changes
Copy link
Collaborator

@megoth megoth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then everything looks good ^_^

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@megoth megoth megoth approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@codam @megoth