Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a problem with dependencies which prevents from running examples on MacOS #738

Conversation

binadamu-isiyoonekana
Copy link

@binadamu-isiyoonekana binadamu-isiyoonekana commented Nov 18, 2024

This PR updates some dependencies so that to be able to run examples (at least on MacOS).

For instance, when trying to execute the simple example, no shape is actually rendered (when executing cargo run --package simple) without this update (again, on a MacOS, x86_64)

@xStrom
Copy link
Member

xStrom commented Nov 18, 2024

The update to wgpu 23 is already ongoing in #735. Can you try running examples using that branch? Would be good to know if your issues go beyond the wgpu update.

@binadamu-isiyoonekana
Copy link
Author

The update to wgpu 23 is already ongoing in #735. Can you try running examples using that branch? Would be good to know if your issues go beyond the wgpu update.

Ooops... I did not see #735 PR. Sorry. It in fact fixes the same issue. So let me close this PR.

@waywardmonkeys
Copy link
Contributor

I'm confused as to why simple isn't rendering something and with_winit is ... that seems to be a bug that should be looked into separately from the update of wgpu?

@binadamu-isiyoonekana
Copy link
Author

I'm confused as to why simple isn't rendering something and with_winit is ... that seems to be a bug that should be looked into separately from the update of wgpu?

Hello. On my side (MacOS x86_64), the simple example is now running correctly with the updates I did in this PR (same as yours, apparently, namely just upgrading wgpu).

@waywardmonkeys
Copy link
Contributor

Right, but the question is "Why is it failing in just the one example?" and going back, it seems to be failing for a while for me too. Is this due to an OS update or ... ?

@waywardmonkeys
Copy link
Contributor

(I'm seeing the problem on an M3 Pro Max laptop running latest macOS.)

@binadamu-isiyoonekana
Copy link
Author

Right, but the question is "Why is it failing in just the one example?" and going back, it seems to be failing for a while for me too. Is this due to an OS update or ... ?

Gotcha! Now I understand your question. I'll also dig more on my side.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants