Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert workaround for miscompilation #527

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Revert workaround for miscompilation #527

wants to merge 1 commit into from

Commits on Mar 21, 2024

  1. Revert workaround for miscompilation 

    We have an ugly workaround for miscompilation of a workgroup uniform load (see #199). The miscompilation no longer repros, and it's not clear we still need it. Possibly something changed in naga, or possibly Apple drivers have improved.

It would be possible to go a little further and trim the allocation of the Paths array so it's not rounded up to workgroup size, but the practical benefit of that is marginal.

Sending this as a PR to see if there still may be problems.
    @raphlinus
    raphlinus committed Mar 21, 2024
    Configuration menu
    Copy the full SHA
    92e8303 View commit details
    Browse the repository at this point in the history