Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add unit test for procnettcp.ParseAddress #2914

Merged
merged 1 commit into from
Nov 24, 2024
Merged

Add unit test for procnettcp.ParseAddress #2914

merged 1 commit into from
Nov 24, 2024

Conversation

alexandear
Copy link
Member

@alexandear alexandear commented Nov 15, 2024 •
edited
Loading

This PR adds unit test for the procnettcp.ParseAddress function.

All lines are covered:

image

jandubois
jandubois requested changes Nov 16, 2024
View reviewed changes
Copy link
Member

@jandubois jandubois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, the tests are good, but I think they can be improved a little.

pkg/guestagent/procnettcp/procnettcp_test.go Outdated Show resolved Hide resolved
pkg/guestagent/procnettcp/procnettcp_test.go Outdated Show resolved Hide resolved
pkg/guestagent/procnettcp/procnettcp_test.go Outdated Show resolved Hide resolved
@alexandear alexandear added area/test Tests and CI and removed area/test Tests and CI labels Nov 23, 2024
jandubois
jandubois approved these changes Nov 24, 2024
View reviewed changes
Copy link
Member

@jandubois jandubois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM

@jandubois jandubois merged commit 9fdd4c8 into lima-vm:master Nov 24, 2024
29 checks passed
@alexandear alexandear deleted the procnettcp-parse-address-test branch November 24, 2024 09:39
@AkihiroSuda AkihiroSuda added this to the v1.0.2 milestone Nov 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jandubois jandubois jandubois approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.0.2
Development

Successfully merging this pull request may close these issues.
3 participants
@alexandear @jandubois @AkihiroSuda