Use printf instead of $'' to pass a multi-line string to bash

[jandubois]

The script will be executed by the default shell of the ssh user, and fish does not support the $'' syntax.

Fixes #2856

Seems to work:

$ limactl shell alpine
Welcome to fish, the friendly interactive shell
Type help for instructions on how to use fish
jan@lima-alpine /U/jan>

[jandubois]

Seems like TEST| [INFO] Testing that PARAM env variables are exported to all types of provisioning scripts and probes is failing...

[AkihiroSuda]

Can we move this to v1.0.2?

[jandubois]

Can we move this to v1.0.2?

Sure. It is a regression to pre-1.0.0 releases, but only affects users that have switched their default shell inside the instance to fish.

[jandubois]

Seems like TEST| [INFO] Testing that PARAM env variables are exported to all types of provisioning scripts and probes is failing...

Just a small quoting issue; should be all good now.

[jandubois]

All these replacements are not really needed because the input strings don't include % or ' characters. but it feels like the right thing to do to make them correct for that case as well.

[norio-nomura]

LGTM 👍🏻
However, I feel that ssh.ExecuteScript should use shellwords.Parse to split the first line into a command and arguments rather than using the entire line as the command itself.

[jandubois]

LGTM 👍🏻

🙏

However, I feel that ssh.ExecuteScript should use shellwords.Parse to split the first line into a command and arguments rather than using the entire line as the command itself.

Given that ssh.ExecuteScript is in https://github.com/lima-vm/sshocker/blob/master/pkg/ssh/ssh.go (in a different repo), and that this is a separate issue from what this PR is trying to fix, I assume you will create a different issue for that.