Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update inject-cmdline-to-template.sh #2863

Merged

Conversation

norio-nomura
Copy link
Contributor

@norio-nomura norio-nomura commented Nov 7, 2024

  • use limactl edit instead of yq -i
  • simplify yq filter
  • add armv7l and riscv64 to arch
  • change default_cmdline for minimal flavor
    use root=/dev/vda1 instead of root=LABEL=cloudimg-rootfs to avoid failing boot
    [    0.127771] /dev/root: Can't open blockdev
    [    0.127797] VFS: Cannot open root device "LABEL=cloudimg-rootfs" or unknown-block(0,0): error -6
    [    0.127908] Please append a correct "root=" boot option; here are the available partitions:
  • inject provision[0].script systemctl enable systemd-time-wait-sync.service
    Booting with a kernel image lacks an RTC, so time synchronization is needed to prevent network errors.

@AkihiroSuda AkihiroSuda added area/test Tests and CI kind/refactoring Refactoring labels Nov 7, 2024
@norio-nomura norio-nomura force-pushed the update-injectcmdline-to-template.sh branch from 8eff27b to 5076ab4 Compare November 7, 2024 06:32
@norio-nomura norio-nomura force-pushed the update-injectcmdline-to-template.sh branch from 5076ab4 to 37ebc42 Compare November 8, 2024 03:09
@norio-nomura
Copy link
Contributor Author

Are the tests failing on macOS-12 possibly failing in the same way as the issue fixed in #2640?

@norio-nomura norio-nomura force-pushed the update-injectcmdline-to-template.sh branch from 8d4cd24 to b3927fc Compare November 8, 2024 10:10
@norio-nomura norio-nomura marked this pull request as draft November 8, 2024 10:18
@norio-nomura norio-nomura force-pushed the update-injectcmdline-to-template.sh branch from b3927fc to d07eef3 Compare November 11, 2024 23:46
@norio-nomura
Copy link
Contributor Author

  • inject provision[0].script systemctl enable systemd-time-wait-sync.service

Removed the above and instead opened #2894

@norio-nomura norio-nomura marked this pull request as ready for review November 12, 2024 03:32
@AkihiroSuda
Copy link
Member

What is the problem with root=LABEL=cloudimg-rootfs?

@norio-nomura
Copy link
Contributor Author

What is the problem with root=LABEL=cloudimg-rootfs?

The kernel image with minimal flavor image fails to boot:

[    0.127771] /dev/root: Can't open blockdev
[    0.127797] VFS: Cannot open root device "LABEL=cloudimg-rootfs" or unknown-block(0,0): error -6
[    0.127908] Please append a correct "root=" boot option; here are the available partitions:

@AkihiroSuda AkihiroSuda added this to the v1.0.2 milestone Nov 20, 2024
Copy link
Member

@AkihiroSuda AkihiroSuda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@AkihiroSuda AkihiroSuda merged commit af4e870 into lima-vm:master Nov 20, 2024
29 checks passed
@norio-nomura norio-nomura deleted the update-injectcmdline-to-template.sh branch November 20, 2024 03:22
@norio-nomura
Copy link
Contributor Author

Thanks! 🙏🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/test Tests and CI kind/refactoring Refactoring
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants