Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow symfony 7 and also test against PHP 8.3 #46

Merged
merged 3 commits into from
Jul 19, 2024

Conversation

Spea
Copy link
Contributor

@Spea Spea commented Jul 19, 2024

I made the following changes here:

  • Allow symfony 7
    This version is already out for a while, so its probably a good idea to allow it as well. I'm not sure if it would make sense to drop support for symfony below 5.4 as those versions no longer receive any updates. Please let me know if I should update the version constraints here.
  • Adjust the test matrix to also test against PHP 8.3
  • Update rector to the latest version
    A few rules were deprecated and had to be replaced with newer ones, but other than that, nothing much changed.

Spea added 3 commits July 19, 2024 17:07
Symfony 7 is out for a while, so it makes sense to add support for it.
Copy link
Member

@dbu dbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

i am in favor of dropping old versions when they become for some reason an issue. just allowing them does not hurt imho - until we want to use some new feature that is not available in EOL versions.

@dbu dbu merged commit 670c2e4 into liip:2.x Jul 19, 2024
7 checks passed
@Spea Spea deleted the allow-symfony-7 branch July 19, 2024 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants