Add dnsmasq as an optional container #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chregu
changed the title
Aerzas
suggested changes
Oct 10, 2019
|
|
||
| ADD dnsmasq.conf /etc/ | ||
|
|
||
| EXPOSE 53 53/udp |
There was a problem hiding this comment.
I would probably avoid creating an image with a root user just in case.
| #log all dns queries | ||
| log-queries | ||
| #dont use hosts nameservers | ||
| no-resolv |
There was a problem hiding this comment.
Should we consider no-hosts also ?
| @@ -0,0 +1,51 @@ | |||
| #!/usr/bin/env bash | |||
There was a problem hiding this comment.
Maybe this part should added to pontsun-cli rather than here ?
| @@ -0,0 +1,8 @@ | |||
| FROM alpine:edge | |||
There was a problem hiding this comment.
Ideally this should not be part of this repo but available as a global image on the Liip docker registry.
There was a problem hiding this comment.
where would you put the Dockerfile then?
There was a problem hiding this comment.
Maybe in a dedicated repo so it can be managed in parallel of Pontsun. But this can be later of course.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Up for discussion on the details
Not sure, if the
add-host.shis too much for this project, or if this should go to pontsun-cli.