-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add support for dbal 4 #299
base: 2.x
Are you sure you want to change the base?
Conversation
Co-authored-by: Alexis Lefebvre <[email protected]>
Solving #300 would help development. |
On the
Update: you found the issue: |
Please check this: Feel free to backport it to the |
Tests were OK on local environment but not on CI, because the versions of databases used on GitHub Actions were outdated: bf29b7d |
@@ -36,7 +36,7 @@ protected function getPlatformName(): string | |||
// AbstractMySQLPlatform was introduced in DBAL 3.3, keep the MySQLPlatform checks for compatibility with older versions | |||
if ($platform instanceof AbstractMySQLPlatform || $platform instanceof MySqlPlatform) { | |||
return 'mysql'; | |||
} elseif ($platform instanceof SqlitePlatform) { | |||
} elseif ($platform instanceof SQLitePlatform) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
} elseif ($platform instanceof SQLitePlatform) { | |
} elseif ($platform instanceof SqlitePlatform || $platform instanceof SQLitePlatform) { |
Is this needed to keep compatibility?
@@ -166,6 +166,6 @@ protected function enableForeignKeyChecksIfApplicable(): void | |||
|
|||
private function isSqlite(): bool | |||
{ | |||
return $this->connection->getDatabasePlatform() instanceof SqlitePlatform; | |||
return $this->connection->getDatabasePlatform() instanceof SQLitePlatform; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
return $this->connection->getDatabasePlatform() instanceof SQLitePlatform; | |
return $this->connection->getDatabasePlatform() instanceof SqlitePlatform || $this->connection->getDatabasePlatform() instanceof SQLitePlatform; |
Is this needed to keep compatibility?
#298
Maybe the only problem is this change.
https://github.com/doctrine/dbal/blob/4.0.x/UPGRADE.md#bc-break-renamed-sqlite-platform-classes
TODO: I know there must be a bc layer for dbal < 4