chore: persist and flush fixtures only once, and remove call to clone

liip · Jul 3, 2024 · 68db9c6 · 68db9c6
1 parent 437e674
commit 68db9c6
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/tests/App/DataFixtures/ORM/LoadUserData.php b/tests/App/DataFixtures/ORM/LoadUserData.php
@@ -27,7 +27,6 @@ public function load(ObjectManager $manager): void
         $user->setEmail('[email protected]');
 
         $manager->persist($user);
-        $manager->flush();
 
         $this->addReference('user', $user);
 

diff --git a/tests/AppConfigMongodb/DataFixtures/MongoDB/LoadUserDataFixture.php b/tests/AppConfigMongodb/DataFixtures/MongoDB/LoadUserDataFixture.php
@@ -32,13 +32,14 @@ public function load(ObjectManager $manager): void
         $user->setEmail('[email protected]');
 
         $manager->persist($user);
-        $manager->flush();
 
         $this->addReference('user', $user);
 
-        $user = clone $this->getReference('user');
+        $user2 = new User();
+        $user2->setName('alice bar');
+        $user2->setEmail('[email protected]');
 
-        $manager->persist($user);
+        $manager->persist($user2);
         $manager->flush();
     }
 }