Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Splicing] Partly handle splice_init & splice_ack messages #3407

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

optout21
Copy link
Contributor

@optout21 optout21 commented Nov 13, 2024

Handle splice_init & splice_ack messages, without performing splicing. splice_init does not error, but splice_ack returns an error (and neither side continues with splicing).
One next piece for splicing #3298 .
This can come before #3137 .

@optout21 optout21 requested a review from jkczyz November 13, 2024 14:52
lightning/src/ln/channelmanager.rs Outdated Show resolved Hide resolved
lightning/src/ln/channelmanager.rs Outdated Show resolved Hide resolved
lightning/src/ln/channelmanager.rs Outdated Show resolved Hide resolved
lightning/src/ln/channel.rs Outdated Show resolved Hide resolved
lightning/src/ln/channel.rs Outdated Show resolved Hide resolved
lightning/src/ln/channel.rs Outdated Show resolved Hide resolved
Copy link

codecov bot commented Nov 18, 2024

Codecov Report

Attention: Patch coverage is 72.72727% with 3 lines in your changes missing coverage. Please review.

Project coverage is 89.23%. Comparing base (0c31021) to head (fb4968c).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
lightning/src/ln/channel.rs 80.00% 2 Missing ⚠️
lightning/src/ln/channelmanager.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3407      +/-   ##
==========================================
+ Coverage   89.22%   89.23%   +0.01%     
==========================================
  Files         130      130              
  Lines      106965   106969       +4     
  Branches   106965   106969       +4     
==========================================
+ Hits        95438    95459      +21     
+ Misses       8734     8720      -14     
+ Partials     2793     2790       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@optout21 optout21 changed the title [Draft, Splicing] Partly handle splice_init & splice_ack messages [Splicing] Partly handle splice_init & splice_ack messages Nov 18, 2024
@optout21 optout21 force-pushed the splice-init branch 2 times, most recently from 19f8ab8 to 4ee3735 Compare November 18, 2024 11:02
@optout21 optout21 marked this pull request as ready for review November 18, 2024 11:03
@optout21 optout21 requested a review from jkczyz November 18, 2024 11:44
lightning/src/ln/channel.rs Show resolved Hide resolved
lightning/src/ln/channelmanager.rs Outdated Show resolved Hide resolved
lightning/src/ln/channelmanager.rs Outdated Show resolved Hide resolved
lightning/src/ln/channel.rs Outdated Show resolved Hide resolved
lightning/src/ln/channel.rs Outdated Show resolved Hide resolved
lightning/src/ln/channel.rs Outdated Show resolved Hide resolved
lightning/src/ln/channel.rs Outdated Show resolved Hide resolved
lightning/src/ln/channel.rs Show resolved Hide resolved
lightning/src/ln/channel.rs Outdated Show resolved Hide resolved
lightning/src/ln/channelmanager.rs Outdated Show resolved Hide resolved
lightning/src/ln/channel.rs Outdated Show resolved Hide resolved
lightning/src/ln/channelmanager.rs Outdated Show resolved Hide resolved
lightning/src/ln/channelmanager.rs Outdated Show resolved Hide resolved
lightning/src/ln/channelmanager.rs Outdated Show resolved Hide resolved
lightning/src/ln/channelmanager.rs Outdated Show resolved Hide resolved
lightning/src/ln/channelmanager.rs Outdated Show resolved Hide resolved
@optout21
Copy link
Contributor Author

I have reorganized code, moved most single-channel checks and handling logic into Channel struct from ChannelManager.

lightning/src/ln/channel.rs Outdated Show resolved Hide resolved
@optout21
Copy link
Contributor Author

Rebased (post #3137) and squashed

@optout21 optout21 requested a review from jkczyz November 21, 2024 10:34
lightning/src/ln/channel.rs Show resolved Hide resolved
lightning/src/ln/channelmanager.rs Outdated Show resolved Hide resolved
lightning/src/ln/channelmanager.rs Outdated Show resolved Hide resolved
lightning/src/ln/channelmanager.rs Outdated Show resolved Hide resolved
lightning/src/ln/channel.rs Outdated Show resolved Hide resolved
lightning/src/ln/channelmanager.rs Outdated Show resolved Hide resolved
lightning/src/ln/channel.rs Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants