Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce custom TLV support for OnionMessage #2830

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Test sending, and receiving of user_custom_tlvs

7399605
Select commit
Loading
Failed to load commit list.
Open

Introduce custom TLV support for OnionMessage #2830

Test sending, and receiving of user_custom_tlvs
7399605
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Nov 26, 2024 in 0s

89.23% (-0.02%) compared to ba3d4ff

View this Pull Request on Codecov

89.23% (-0.02%) compared to ba3d4ff

Details

Codecov Report

Attention: Patch coverage is 95.98854% with 14 lines in your changes missing coverage. Please review.

Project coverage is 89.23%. Comparing base (ba3d4ff) to head (7399605).

Files with missing lines Patch % Lines
lightning/src/ln/outbound_payment.rs 85.71% 3 Missing and 1 partial ⚠️
lightning/src/onion_message/messenger.rs 91.66% 3 Missing ⚠️
lightning-dns-resolver/src/lib.rs 50.00% 2 Missing ⚠️
lightning/src/ln/channelmanager.rs 96.87% 0 Missing and 1 partial ⚠️
lightning/src/ln/msgs.rs 97.72% 0 Missing and 1 partial ⚠️
lightning/src/ln/offers_tests.rs 80.00% 1 Missing ⚠️
lightning/src/ln/peer_handler.rs 0.00% 1 Missing ⚠️
lightning/src/onion_message/functional_tests.rs 98.70% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2830      +/-   ##
==========================================
- Coverage   89.25%   89.23%   -0.02%     
==========================================
  Files         130      130              
  Lines      106959   107116     +157     
  Branches   106959   107116     +157     
==========================================
+ Hits        95464    95590     +126     
- Misses       8706     8727      +21     
- Partials     2789     2799      +10

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov