-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add new sig #886
fix: add new sig #886
Conversation
WalkthroughThe pull request modifies the Changes
Possibly related PRs
Suggested reviewers
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (1)
config/sigs.json
(1 hunks)
🔇 Additional comments (1)
config/sigs.json (1)
155-155
: Verify the function signature and its security implications
Before approving the addition of 0x08298b5a
, please:
- Confirm which function this signature represents
- Verify the contract (
0x2E86f54943faFD2cB62958c3deed36C879e3E944
) on chain81457
- Assess the security implications of allowing this function call
Test Coverage ReportLine Coverage: 76.59% (1725 / 2252 lines) |
…into add-missing-sig-okx
Which Jira task belongs to this PR?
https://lifi.atlassian.net/browse/LF-10597
Why did I implement it this way?
[Signature Allowlist] Unknown signature: 0x08298b5a, chain: 81457, contract: 0x2E86f54943faFD2cB62958c3deed36C879e3E944
Checklist before requesting a review
Checklist for reviewer (DO NOT DEPLOY and contracts BEFORE CHECKING THIS!!!)