Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add new sig #886

Merged
merged 4 commits into from
Nov 28, 2024
Merged

fix: add new sig #886

merged 4 commits into from
Nov 28, 2024

Conversation

myz1237
Copy link
Contributor

@myz1237 myz1237 commented Nov 28, 2024

Which Jira task belongs to this PR?

https://lifi.atlassian.net/browse/LF-10597

Why did I implement it this way?

  • Another missed sign from BE: [Signature Allowlist] Unknown signature: 0x08298b5a, chain: 81457, contract: 0x2E86f54943faFD2cB62958c3deed36C879e3E944
  • Remove duplicated signs advised by coderabbitai

Checklist before requesting a review

  • I have performed a self-review of my code
  • This pull request is as small as possible and only tackles one problem
  • I have added tests that cover the functionality / test the bug
  • I have updated any required documentation

Checklist for reviewer (DO NOT DEPLOY and contracts BEFORE CHECKING THIS!!!)

  • I have checked that any arbitrary calls to external contracts are validated and or restricted
  • I have checked that any privileged calls (i.e. storage modifications) are validated and or restricted
  • I have ensured that any new contracts have had AT A MINIMUM 1 preliminary audit conducted on by <company/auditor>

Copy link
Contributor

coderabbitai bot commented Nov 28, 2024

Walkthrough

The pull request modifies the config/sigs.json file by removing the signature "0x0d5f0e3b" and adding a new signature, "0x08298b5a", while retaining the existing signature "0x91695586". The overall structure of the JSON remains unchanged, with the new signature added to the end of the sigs array.

Changes

File Change Summary
config/sigs.json Added signature "0x08298b5a"; removed signature "0x0d5f0e3b"; retained signature "0x91695586" in the sigs array.

Possibly related PRs

  • config: addresses and signatures for sushiswap dex agg #818: This PR modifies the config/sigs.json file by adding new signatures, which is directly related to the changes made in the main PR that also involves modifications to the sigs array in the same file.
  • config: add signature for openocean #839: This PR adds a new signature to the config/sigs.json file, which is relevant to the main PR's changes that involve adding and removing signatures in the same file.
  • fix: correct okx sign #876: This PR removes a signature from the config/sigs.json file and adds a new one, which is directly related to the main PR's modifications that include the removal and addition of signatures in the same file.
  • feat: add missed signature for OKX #881: This PR adds a new signature to the config/sigs.json file, which aligns with the main PR's changes that involve adding a signature to the same file.

Suggested reviewers

  • 0xDEnYO

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between f48ea12 and 15649fd.

📒 Files selected for processing (1)
  • config/sigs.json (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • config/sigs.json

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@lifi-action-bot lifi-action-bot marked this pull request as draft November 28, 2024 04:06
@myz1237 myz1237 marked this pull request as ready for review November 28, 2024 04:06
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 0241676 and f48ea12.

📒 Files selected for processing (1)
  • config/sigs.json (1 hunks)
🔇 Additional comments (1)
config/sigs.json (1)

155-155: Verify the function signature and its security implications

Before approving the addition of 0x08298b5a, please:

  1. Confirm which function this signature represents
  2. Verify the contract (0x2E86f54943faFD2cB62958c3deed36C879e3E944) on chain 81457
  3. Assess the security implications of allowing this function call

config/sigs.json Show resolved Hide resolved
@lifi-action-bot
Copy link
Collaborator

Test Coverage Report

Line Coverage: 76.59% (1725 / 2252 lines)
Function Coverage: 83.10% ( 364 / 438 functions)
Branch Coverage: 36.21% ( 197 / 544 branches)
Test coverage (76.59%) is above min threshold (76%). Check passed.

@0xDEnYO 0xDEnYO merged commit 8ad497c into main Nov 28, 2024
15 checks passed
@0xDEnYO 0xDEnYO deleted the add-missing-sig-okx branch November 28, 2024 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants