config: add new dodo contracts

[mathiasmoeller]

Which Jira task belongs to this PR?

https://lifi.atlassian.net/browse/LF-11216

Why did I implement it this way?

Here is the BE PR: https://github.com/lifinance/lifi-backend/pull/5897
But we first need to update SC

Checklist before requesting a review

• I have performed a self-review of my code
• This pull request is as small as possible and only tackles one problem
• I have added tests that cover the functionality / test the bug
• I have updated any required documentation

Checklist for reviewer (DO NOT DEPLOY and contracts BEFORE CHECKING THIS!!!)

• I have checked that any arbitrary calls to external contracts are validated and or restricted
• I have checked that any privileged calls (i.e. storage modifications) are validated and or restricted
• I have ensured that any new contracts have had AT A MINIMUM 1 preliminary audit conducted on by <company/auditor>

[coderabbitai]

Walkthrough

The changes involve updates to the config/dexs.json file, specifically in the arrays of Ethereum addresses for various networks. New addresses have been added to the sections for "mainnet," "arbitrum," "avalanche," "blast," "bsc," and "opbnb," while certain existing addresses have been retained across these sections.

Changes

File

Change Summary

config/dexs.json

- Added address 0xFe837A3530dD566401d35beFCd55582AF7c4dfFC in "mainnet" and "arbitrum" sections. - Added address 0x3a64Ec3606FF7310E8fAd6FcC008e39705fB496d in "avalanche" section. - Added address 0x0343C5757Fb98aD9eF39824e08B852aF61C71c64 in "blast" and "bsc" sections. - Added address 0x46AFE01D758a46d64c7d8E0791314D5db3E2e683 in "opbnb" section. - Retained address 0x40aA958dd87FC8305b97f2BA922CDdCa374bcD7f across all sections.

Possibly related PRs

• config: addresses and signatures for sushiswap dex agg #818: This PR also modifies the config/dexs.json file by adding multiple new addresses across various network sections, similar to the changes made in the main PR.
• config: add addresses and signatures for bebop #844: This PR updates the config/dexs.json file by adding a new address and modifying existing entries, which aligns with the main PR's focus on address modifications in the same file.
• feat: add cronos lifidex aggregator address #862: This PR introduces new addresses in the config/dexs.json file, including updates to various network sections, which is directly related to the changes in the main PR.
• feat: add router for okx aggregator #867: This PR introduces new addresses in the config/dexs.json file across various sections, reflecting a similar pattern of updates as seen in the main PR.
• feat: add okx approve contract to dex #878: This PR adds new addresses to the config/dexs.json file, including some that are also present in the main PR, indicating a direct relationship.
• fix: remove trailing comma and bad dex contract for bebop dex #880: This PR modifies the config/dexs.json file by adding new addresses and making formatting adjustments, which relates to the changes in the main PR.

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 53d6189 and d4ab255.

📒 Files selected for processing (1)

• config/dexs.json (8 hunks)

🧰 Additional context used

📓 Learnings (1)

config/dexs.json (1)

Learnt from: ezynda3
PR: lifinance/contracts#861
File: config/dexs.json:748-752
Timestamp: 2024-11-21T08:39:29.530Z
Learning: In the 'worldchain' network, the addresses `0x50D5a8aCFAe13Dceb217E9a071F6c6Bd5bDB4155`, `0x8f023b4193a6b18C227B4a755f8e28B3D30Ef9a1`, and `0x603a538477d44064eA5A5d8C345b4Ff6fca1142a` are used as DEXs and should be included in `config/dexs.json`.

🔇 Additional comments (7)

config/dexs.json (7)

46-47: LGTM: Address additions to mainnet network

The new addresses are properly formatted and follow the existing pattern.

---

157-158: LGTM: Address additions to avalanche network

The new addresses are properly formatted and follow the existing pattern.

---

272-273: LGTM: Address additions to bsc network

The new addresses are properly formatted and follow the existing pattern.

---

530-531: Addresses added to mode network need checksum format

The addresses 0xd0f95fafa06de1b21e79db03c649919501e99ea9 and 0xbd0ebe49779e154e5042b34d5bcfbc498e4b3249 should follow EIP-55 mixed-case checksum format.

However, based on previous feedback from @0xDEnYO, this format is acceptable.

---

705-706: LGTM: Address additions to polygon network

The new addresses are properly formatted and follow the existing pattern.

---

748-749: Addresses added to sei network need checksum format

The addresses 0xdb3af8df1cab8ae4159ed6a9b33df5f8c3ad1485 and 0x801d8ed849039007a7170830623180396492c7ed should follow EIP-55 mixed-case checksum format.

However, based on previous feedback from @0xDEnYO, this format is acceptable.

---

827-827: LGTM: Test network configurations

The test network configurations are properly separated and maintained.

Also applies to: 836-836

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 2

🧹 Outside diff range and nitpick comments (1)

config/dexs.json (1)

841-841: Format the JSON file properly

The file ends with a newline after the closing brace. While this is generally good practice, ensure it's consistent with your project's formatting guidelines.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 207f863 and 53d6189.

📒 Files selected for processing (1)

• config/dexs.json (7 hunks)

🔇 Additional comments (1)

config/dexs.json (1)

46-47: Verify if these addresses are valid DODO contracts

The PR title mentions adding new DODO contracts, but we should verify that these new addresses are indeed DODO-related contracts across different networks.

Also applies to: 157-158, 272-273, 531-531, 706-707, 749-750

[lifi-action-bot]

Test Coverage Report

Line Coverage: 76.59% (1725 / 2252 lines)
Function Coverage: 83.10% ( 364 / 438 functions)
Branch Coverage: 36.21% ( 197 / 544 branches)
Test coverage (76.59%) is above min threshold (76%). Check passed.