Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: sync develop with latest master changes #887

Merged
merged 13 commits into from
Nov 29, 2024
Merged

chore: sync develop with latest master changes #887

merged 13 commits into from
Nov 29, 2024

Conversation

tamtamchik
Copy link
Member

@tamtamchik tamtamchik commented Nov 29, 2024 •
edited
Loading

  • Fix test case when there is no deposit for NOR and CSVT modules
  • Suppress some slither detectors
  • Deduplicate dependencies
  • Update CI action triggers

tamtamchik and others added 9 commits October 10, 2024 22:53
@tamtamchik
ci: fix master coverage
f3ba285
@TheDZhon
Merge pull request #855 from lidofinance/fix/master-coverage
f13e1b6 
ci: fix master coverage
@mymphe
Update README.md
3cbaf17
@TheDZhon
Merge pull request #856 from lidofinance/upd-bugbounty
7266cb9 
Update README.md
@tamtamchik
fix: remove PostTotalShares event checks
b5d521d
@tamtamchik
Merge pull request #866 from lidofinance/feat/adjust-mainnet-state
fb06810 
fix: remove PostTotalShares event checks
@dependabot
build(deps): bump secp256k1 from 4.0.3 to 4.0.4
8b365fd 
Bumps [secp256k1](https://github.com/cryptocoinjs/secp256k1-node) from 4.0.3 to 4.0.4.
- [Release notes](https://github.com/cryptocoinjs/secp256k1-node/releases)
- [Commits](cryptocoinjs/secp256k1-node@v4.0.3...v4.0.4)

---
updated-dependencies:
- dependency-name: secp256k1
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
@TheDZhon
Merge pull request #867 from lidofinance/dependabot/npm_and_yarn/secp…
836dc8e 
…256k1-4.0.4

build(deps): bump secp256k1 from 4.0.3 to 4.0.4
@TheDZhon
Merge pull request #879 from lidofinance/develop
c19480a 
SR 1.5
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 29, 2024 •
edited
Loading

badge

Hardhat Unit Tests Coverage Summary

Filename                                                       Stmts    Miss  Cover    Missing
-----------------------------------------------------------  -------  ------  -------  ---------
contracts/0.4.24/Lido.sol                                        212       0  100.00%
contracts/0.4.24/StETH.sol                                        72       0  100.00%
contracts/0.4.24/StETHPermit.sol                                  15       0  100.00%
contracts/0.4.24/lib/Packed64x4.sol                                5       0  100.00%
contracts/0.4.24/lib/SigningKeys.sol                              36       0  100.00%
contracts/0.4.24/lib/StakeLimitUtils.sol                          37       0  100.00%
contracts/0.4.24/nos/NodeOperatorsRegistry.sol                   512       0  100.00%
contracts/0.4.24/oracle/LegacyOracle.sol                          72       0  100.00%
contracts/0.4.24/utils/Pausable.sol                                9       0  100.00%
contracts/0.4.24/utils/Versioned.sol                               5       0  100.00%
contracts/0.6.12/WstETH.sol                                       17       0  100.00%
contracts/0.8.4/WithdrawalsManagerProxy.sol                       61       0  100.00%
contracts/0.8.9/BeaconChainDepositor.sol                          21       2  90.48%   48, 51
contracts/0.8.9/Burner.sol                                        71       0  100.00%
contracts/0.8.9/DepositSecurityModule.sol                        128       0  100.00%
contracts/0.8.9/EIP712StETH.sol                                   16       0  100.00%
contracts/0.8.9/LidoExecutionLayerRewardsVault.sol                16       0  100.00%
contracts/0.8.9/LidoLocator.sol                                   18       0  100.00%
contracts/0.8.9/OracleDaemonConfig.sol                            28       0  100.00%
contracts/0.8.9/StakingRouter.sol                                316       0  100.00%
contracts/0.8.9/WithdrawalQueue.sol                               88       0  100.00%
contracts/0.8.9/WithdrawalQueueBase.sol                          146       0  100.00%
contracts/0.8.9/WithdrawalQueueERC721.sol                         89       0  100.00%
contracts/0.8.9/WithdrawalVault.sol                               21       0  100.00%
contracts/0.8.9/lib/Math.sol                                       4       0  100.00%
contracts/0.8.9/lib/PositiveTokenRebaseLimiter.sol                22       0  100.00%
contracts/0.8.9/lib/UnstructuredRefStorage.sol                     2       0  100.00%
contracts/0.8.9/oracle/AccountingOracle.sol                      190       2  98.95%   189-190
contracts/0.8.9/oracle/BaseOracle.sol                             89       1  98.88%   397
contracts/0.8.9/oracle/HashConsensus.sol                         263       1  99.62%   1005
contracts/0.8.9/oracle/ValidatorsExitBusOracle.sol                91      91  0.00%    96-461
contracts/0.8.9/proxy/OssifiableProxy.sol                         17       0  100.00%
contracts/0.8.9/sanity_checks/OracleReportSanityChecker.sol      232       0  100.00%
contracts/0.8.9/utils/DummyEmptyContract.sol                       0       0  100.00%
contracts/0.8.9/utils/PausableUntil.sol                           31       0  100.00%
contracts/0.8.9/utils/Versioned.sol                               11       0  100.00%
contracts/0.8.9/utils/access/AccessControl.sol                    23       0  100.00%
contracts/0.8.9/utils/access/AccessControlEnumerable.sol           9       0  100.00%
contracts/testnets/sepolia/SepoliaDepositAdapter.sol              21      21  0.00%    49-100
TOTAL                                                           3016     118  96.09%

Diff against master

Filename      Stmts    Miss  Cover
----------  -------  ------  --------
TOTAL             0       0  +100.00%

Results for commit: de2cbd0

Minimum allowed coverage is 95%

♻️ This comment has been updated with latest results

@tamtamchik tamtamchik marked this pull request as ready for review November 29, 2024 14:00
@tamtamchik tamtamchik requested a review from a team as a code owner November 29, 2024 14:00
rnmsslido
rnmsslido approved these changes Nov 29, 2024
View reviewed changes
Copy link

@rnmsslido rnmsslido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for changes to .github/workflows.
Before merging, please ensure additional reviews are obtained for the other changes in this PR.

folkyatina
folkyatina approved these changes Nov 29, 2024
View reviewed changes
Copy link
Member

@folkyatina folkyatina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tamtamchik tamtamchik merged commit 04ba700 into develop Nov 29, 2024
10 checks passed
@tamtamchik tamtamchik deleted the feat/sync-develop branch November 29, 2024 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rnmsslido rnmsslido rnmsslido approved these changes

@folkyatina folkyatina folkyatina approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@tamtamchik @folkyatina @rnmsslido @TheDZhon @mymphe