heifsave: expose libheif/aom auto_tiles feature #4191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allows the aom encoder to determine the optimum tile count based on the output dimensions and available threads. This can improve multi-core utilisation, reducing processing time and/or memory usage at the cost of slightly increased file sizes.
lovell
force-pushed
the
heifsave-auto-tiles
branch
from
966d879
to
7cd2748
Compare
|
Sure, that sounds like a very useful speedup. I'll update ChangeLog and the 8.16 release notes. |
|
Sorry, I was thinking about this overnight. If the filesize increase is very small, how about we just enable this by default? |
|
Yes, I like that idea. I guess there's a possibility for artefacts to be introduced along the edges of tiles but I didn't notice this in my testing. |
jcupitt
added a commit
that referenced
this pull request
Oct 12, 2024
just turn it on by default see #4191 (comment)
|
OK, I made it always on. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I realise we don't want to expose every single possible underlying encoder feature, however given the relatively poor encoding times of AVIF images this one feels like the most useful addition to libaom I've seen in a while.
The
auto_tilesproperty allows the aom encoder to determine the optimum tile count based on the output dimensions and available threads, which in my testing seriously improves multi-core utilisation. Elapsed time is almost halved in some cases. There are claims it reduces memory usage but I've not found much evidence of this yet. The cost of all this is very slightly increased file sizes, mostly from the additional metadata.The upstream PR for this was strukturag/libheif#1330 (requires libaom v3.10.0+ and the forthcoming libheif v1.18.3+).