Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

identify: add a sequence number to the Identify protobuf #502

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

identify: add a sequence number to the Identify protobuf #502

wants to merge 2 commits into from

Conversation

marten-seemann
Copy link
Contributor

Fixes #501.

MarcoPolo
MarcoPolo requested changes Jan 7, 2023
View reviewed changes
Copy link
Contributor

@MarcoPolo MarcoPolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once the wording change is in, request a review and I'll approve

@marten-seemann
Copy link
Contributor Author

Sorry for the delay, I just added the paragraph as suggested.

mxinden
mxinden approved these changes Feb 24, 2023
View reviewed changes
Copy link
Member

@mxinden mxinden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the addition.

@thomaseizinger thomaseizinger mentioned this pull request May 23, 2023
Open
@p-shahi
Copy link
Member

p-shahi commented Sep 10, 2024

This PR has the sufficient approvals, @marten-seemann can this be merged?

@marten-seemann
Copy link
Contributor Author

@p-shahi Maybe, that's for you guys to decide now...

Looking back at the text, I'm not sure I like the fact that this is cross-connection.

@achingbrain achingbrain mentioned this pull request Sep 11, 2024
Open
2color added a commit that referenced this pull request Sep 11, 2024
@2color
chore: update revision
ba3d797 
use r3 to account for #502
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Menduist Menduist Menduist left review comments

@mxinden mxinden mxinden approved these changes

@MarcoPolo MarcoPolo MarcoPolo approved these changes

@Stebalien Stebalien Awaiting requested review from Stebalien

Assignees
No one assigned
Labels
None yet
Projects
libp2p Specs
Status: Triage
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

identify: multiple Push messages are racy
5 participants
@marten-seemann @p-shahi @MarcoPolo @mxinden @Menduist