-
Notifications
You must be signed in to change notification settings - Fork 942
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SSL Context Callback #1021
Open
COM8
wants to merge
9
commits into
master
Choose a base branch
from
feature/ssl_ctx_callback
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
SSL Context Callback #1021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
arekmula
approved these changes
Jan 28, 2024
Docs: libcpr/docs#44 |
Currently still WIP since something seams to be broken when using this functionality when cpr is used via fetch content e.g. in our example repo. Unit tests as well as sanitizers do not find anything yet... |
COM8
force-pushed
the
feature/ssl_ctx_callback
branch
2 times, most recently
from
May 30, 2024 04:58
4b2f86c
to
4a460b7
Compare
COM8
force-pushed
the
feature/ssl_ctx_callback
branch
from
July 10, 2024 07:57
0bd7dcb
to
eebff44
Compare
COM8
force-pushed
the
feature/ssl_ctx_callback
branch
from
September 26, 2024 15:52
eebff44
to
59ddfd0
Compare
COM8
force-pushed
the
feature/ssl_ctx_callback
branch
from
October 13, 2024 06:19
b98838e
to
ddb2a2e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #1019.
As an extension to #1020 this PR adds a function that gets called by libcurl just before the initialization of an SSL connection after having processed all other SSL related options to give a last chance to an application to modify the behavior of the SSL initialization.
Ref: https://curl.se/libcurl/c/CURLOPT_SSL_CTX_FUNCTION.html
How to use:
This option is incompatible with
cpr::ssl::CaBuffer
. In case both options are present an instance ofstd::logic_error
gets thrown while performing the request.