Remove viper config serialization #926
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like something broken: https://github.com/lf-edge/eden/actions/runs/6902762877/job/18780102814#step:11:21. As I can see there is double |
uncleDecart
force-pushed
the
remove-viper-config-serialization
branch
from
1328f39
to
8ddcc61
Compare
|
Let's try this one :) |
|
There are some more changes needed in test cmd |
uncleDecart
force-pushed
the
remove-viper-config-serialization
branch
from
8ddcc61
to
6a091fe
Compare
|
Okaay, test cmd fixed, let's see how it runs 🤞 |
|
That's weird, locally smoke tests are running, in CI/CD tests are green, but I think they didn't run (10 mins is way to less for tests to finish) |
|
log_tests is failing, something is wrong with certificate path, looking into it... |
uncleDecart
force-pushed
the
remove-viper-config-serialization
branch
from
6a091fe
to
e224bb8
Compare
Signed-off-by: Pavel Abramov <[email protected]>
Signed-off-by: Pavel Abramov <[email protected]>
Signed-off-by: Pavel Abramov <[email protected]>
Signed-off-by: Pavel Abramov <[email protected]>
Signed-off-by: Pavel Abramov <[email protected]>
Signed-off-by: Pavel Abramov <[email protected]>
Signed-off-by: Pavel Abramov <[email protected]>
Signed-off-by: Pavel Abramov <[email protected]>
cleanContext is only used in OpenEVEC EdenClean function. Tightly coupled functions should be in one module. Also, there is cloudPrepare function which uses viper, which we will change Signed-off-by: Pavel Abramov <[email protected]>
Previously, this functions used viper to fetch variables, since we want to decouple openevec and viper, now they use EdenSetupArgs to fetch parameters Signed-off-by: Pavel Abramov <[email protected]>
Signed-off-by: Pavel Abramov <[email protected]>
Signed-off-by: Pavel Abramov <[email protected]>
Signed-off-by: Pavel Abramov <[email protected]>
uncleDecart
force-pushed
the
remove-viper-config-serialization
branch
from
e224bb8
to
d5c21ea
Compare
|
tests are passing, but we are failing on getting logs, checking what's up |
|
superseded by #1037 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This continues work on removing viper from openevec package so that we can create default configuration structure and use it to call openevec functions in golang.
In this PR use EdenSetupArgs default generated config in config add function. That means that we remove configuration generated from templates (so there are no comments or spacing in file, just pure yml, we can, of course add template comments to struct fields in go file)
Also we force cloudPrepare() function to use EdenSetupArgs, because before it fetched variables from viper, which creates unnecessary coupling and forces us to create file and use viper in openevec.
So far I played with default parameters, will try to change configurations.