add security test suite to eden #917
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uncleDecart
approved these changes
Nov 3, 2023
There was a problem hiding this comment.
LGTM, thank you @shjala for this!
cc: @milan-zededa and @giggsoff for suggestions, comments if any
|
I will fix the yetus complains. |
uncleDecart
reviewed
Nov 3, 2023
tests/sec/sec_test.go
Outdated
| @@ -0,0 +1,110 @@ | |||
| package sec | |||
There was a problem hiding this comment.
That's a reasonable complaint
shjala
force-pushed
the
sec_test
branch
2 times, most recently
from
f3cc7e1
to
6e5158d
Compare
Signed-off-by: Shahriyar Jalayeri <[email protected]>
milan-zededa
reviewed
Nov 6, 2023
There was a problem hiding this comment.
Overall this is OK, although there is quite a lot of boiler-plate out of which only one line is the actual test. Currently, I would not say that writing eden tests in golang is easier than with escript, but hopefully over time we can improve the test framework and make it more user friendly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds security test suite to eden. As suggested by @uncleDecart, to liberate ourselves from bash and eden script, it is written in go ;)
For now it just check apparmor enablement, more to be added to the suite.