Fix http datastore fqdn address #1005
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uncleDecart
approved these changes
Jul 24, 2024
There was a problem hiding this comment.
LGTM, thanks @shjala ! Could you please add comment from your commit to the change, so it won't be gone if we rewrite commit? I think it's a useful comment for people :)
I'm not sure what you mean, this is the commit message, should I add more to it? |
shjala
force-pushed
the
fix_http_pod_deploy
branch
from
f885f75
to
a81166f
Compare
|
@uncleDecart got it, added. |
giggsoff
reviewed
Jul 24, 2024
pkg/expect/http.go
Outdated
| // In case the http datastore address has a port number, | ||
| // the datastore address should contain both the hostname and the port. | ||
| if u.Port() != "" { | ||
| ds.Fqdn = fmt.Sprintf("%s:%s", ds.Fqdn, u.Port()) |
There was a problem hiding this comment.
Can we use u.Host instead in both cases (as full host:port notation), looks like it contains the port and u.Port() just extracts it from u.Host.
In case the http datastore address has a port number, the datastore address should contain both the hostname and the port. Signed-off-by: Shahriyar Jalayeri <[email protected]>
shjala
force-pushed
the
fix_http_pod_deploy
branch
from
a81166f
to
39ec469
Compare
giggsoff
approved these changes
Jul 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case the http datastore address has a port number, the datastore address should contain both the hostname and the port.