-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lattice Symmetries #85
base: master
Are you sure you want to change the base?
Conversation
Hello @Olllom! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:
Comment last updated at 2021-07-06 18:11:27 UTC |
This pull request introduces 2 alerts when merging 22e68f7 into 15f5047 - view on LGTM.com new alerts:
|
This pull request introduces 1 alert when merging 772144c into 15f5047 - view on LGTM.com new alerts:
|
This pull request introduces 1 alert when merging 4c58554 into 80699e3 - view on LGTM.com new alerts:
|
This is a first attempt to formalize the incorporation of lattice symmetries into collision models. For now it mainly automates finding the symmetries of each stencil and converting them into the respective index permutations. The current version at least allows us to check if a collision model obeys all desired lattice symmetries (see the last test in test_symmetry.py)
The code for such a check would look like this:
Breaking Change:
Swapped the order of
transform
andrelaxation_parameters
in the MRT collision model constructor.@McBs