-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tests for new native based lettuce version #213
Merged
PhiSpel
merged 122 commits into
master
from
172-adjust-and-adapt-tests-for-new-native-based-lettuce-version
Aug 22, 2024
Merged
tests for new native based lettuce version #213
PhiSpel
merged 122 commits into
master
from
172-adjust-and-adapt-tests-for-new-native-based-lettuce-version
Aug 22, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
19 tasks
…72-adjust-and-adapt-tests-for-new-native-based-lettuce-version
12 tasks
added optional f to flow.j() added conserving_collisions fixture
…tead of returning different lists in device_params
…-version' into 112-convergence-tool-should-be-run-as-a-test
…tead of returning different lists in device_params
…tead of returning different lists in device_params
* Update CI.yml (#228) runs-on: self-hosted (workstation-mcbs) * Update CI.yml (#229) * Update CI.yml * Update CI.yml * Update CI.yml * removed conftest.py * renamed common.py to conftest.py for pytest to recognize it * not importing Flow to moments.py * not importing Flow to inc_quad_eq only import TorchStencil to _flow * removed default Transform imports to avoid cyclic import * pep8 cosmetics --------- Co-authored-by: Mario Bedrunka <[email protected]>
* added test_checkpoint and adapted poiseuille.py flow to new architecture * pep8 cosmetics
…-version' into 112-convergence-tool-should-be-run-as-a-test
…-version' into 112-convergence-tool-should-be-run-as-a-test
PhiSpel
changed the title
172 adjust and adapt tests for new native based lettuce version
adjust and adapt tests for new native based lettuce version
Aug 22, 2024
PhiSpel
changed the title
adjust and adapt tests for new native based lettuce version
tests for new native based lettuce version
Aug 22, 2024
…e-run-as-a-test running convergence tool as a test
…new-native-based-lettuce-version # Conflicts: # lettuce/util/moments.py # tests/native/test_native_bgk_collision.py
…new-native-based-lettuce-version
McBs
approved these changes
Aug 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm. Thanks! :-)
PhiSpel
deleted the
172-adjust-and-adapt-tests-for-new-native-based-lettuce-version
branch
August 22, 2024 14:12
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
closes #172
closes #112
closes #119
closes #186
Checklist
Did you add a new method? If so, you need toadd method descriptionmaybe mention class in the corresponding__init__
add an example using the method inexamples/advanced_flows/
orexamples/simple_flows/
add a test intests/
Synopsis
Flow
:f
inputs to methods optionalf
torho()
- this is a continuation of Update examples to cuda-native architecture #198initialize_pressure
andinitialize_fneq
properties (default False) and, depending on them, additionalpressure_poisson
andinitialize_fneq
methods. The latter could still be in a different file, but they are only used inFlow
.Boundary
Flow
instead ofContext
to get thetorch_stencil
flow.collision
inAntiBounceBackOutlet
as this is not always available (see [Feature]: Let boundaries choose to affect collision OR streaming #212)Transform
: I worked around the issue of things such asmv()
belonging toFlow
(see [Bug]: Moment transforms require many methods from deprecated Lattice #222).BGKCollision
: removed redundant call offlow.rho()
BGKInitialisation
: removed as deprecatedCouetteFlow
: Cosmetics and generalized u0DecayingTurbulence
:super()
call.initialize_fneq
andinitialize_pressure
DoublyPeriodicShear2D
:self.resolution
initialize_fneq
LidDrivenCavity
: CosmeticsObstacle
: CosmeticsPoiseuille
:TaylorGreenVortex
:stencil
properlyinitialize_fneq
Force
,Guo
,ShanChen
: Added abstract__init__
usingFlow
instead ofContext
forGuo
to have access totorch_stencil
,Guo
: updated to native architectureErrorReporter
: cosmeticsObservableReporter
: MadeObservable
an ABC Class and madef
inputs optionalVTKReporter
: changed convert_to_numpy to convert_to_ndarrayHDF5Reporter
: Update to native and inherit fromReporter
classmoments.py
:stencil
as class or as instancelattice
tocontext
Flow
toTransform.equilibrium()
to get its equilibrium, densitiy, and velocityeinsum
andmv
to be independent of changes in.../_Flow/
utility.py
:pressure_poisson
to.../_Flow/
./old_tests/
conftest.py
: This is now all intests/common.py
test_readme.py
: This is tedious to update manually and in Update README.rst #157 I suggest anyway to remove the code snippet and instead to refer straight to the example files.tests/common.py
: Added collection ofCollision
subclasses and those with conservation properties.tests/native/__init__.py
: Skipping native tests alltogether if cuda is not available (in CI).tests/simulation
:test_load_and_dump
b/csave_checkpoint
is deprecated and we should deal with this whole issue separately in HDF5 Writer limits grid resolution #119 and added a test for dump and load #224test_initialization
totest_initialize_pressure
(non-Jacobi was discouraged anyway)