Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow video_index, resolution and fps to be specified on commandline #19

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

bobek
Copy link

@bobek bobek commented Sep 11, 2021

This will allow for use on different computers and with weird USB cameras.

My USB camera is aliexpress breed, which is quite picky about resolution+fps combinations. Also as I am using notebook as a device for doing analysis, the video0 is typically internal camera.

I came across #13 only after introducing these changes, but approach seems to be quite compatible. I would also like to second @rafl question about code organization and suggest having just one file pyspectrometer.py and use git tags for version tracking.

Copy link

@ckuethe ckuethe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aside from your comments, I came up with basically the very same diff this morning, though I just used .lower().split('x') for the resolution parsing.

I'm using my laptop which has an internal webcam, and indeed my external camera is something cheap and terrible that doesn't like 25fps but if I skip setting capture rate then it behaves quite sensibly.

I recommend merging this diff, cuz I have a few more changes to go on top of it :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants