Allow video_index, resolution and fps to be specified on commandline #19
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will allow for use on different computers and with weird USB cameras.
My USB camera is aliexpress breed, which is quite picky about resolution+fps combinations. Also as I am using notebook as a device for doing analysis, the
video0
is typically internal camera.I came across #13 only after introducing these changes, but approach seems to be quite compatible. I would also like to second @rafl question about code organization and suggest having just one file
pyspectrometer.py
and use git tags for version tracking.