Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Aquire semaphore when network will be accessed (#25)" #31

Merged
merged 1 commit into from
Jul 12, 2024

Conversation

natenjoy
Copy link

This reverts commit e73952d. Looks like this optimization wasn't safe and caused issues with the reused request pointer being shared, which ended up in a scenario where the channel could be closed and then sent on. Thanks for pointing this out, @TheJokr .

Likely to fix #30

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.25%. Comparing base (8a18d6d) to head (09149a0).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #31      +/-   ##
==========================================
- Coverage   64.01%   63.25%   -0.77%     
==========================================
  Files           6        6              
  Lines         503      430      -73     
==========================================
- Hits          322      272      -50     
+ Misses        168      145      -23     
  Partials       13       13              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lestrrat
Copy link
Collaborator

thanks!

@lestrrat lestrrat merged commit c053183 into lestrrat-go:main Jul 12, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants