fix: avoid hitting Github limit on commit status updates #688
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fsaintjacques
approved these changes
Oct 18, 2024
|
Can we also swallow the error when the limit is hit, this is non recoverable as it will never move forward. |
I've updated the PR to log and swallow the error. I've done this for any error resulting from the reporter because - as I've commented - sending updates is "best-effort". |
leg100
pushed a commit
that referenced
this pull request
Oct 22, 2024
🤖 I have created a release *beep* *boop* --- ## [0.3.0](v0.2.4...v0.3.0) (2024-10-22) ### ⚠ BREAKING CHANGES * rename --address flag to --url; require scheme * move to sqlc, tern ([#683](#683)) ### refactor * move to sqlc, tern ([#683](#683)) ([878ebfb](878ebfb)) * rename --address flag to --url; require scheme ([3e83474](3e83474)) ### Features * add timeout settings for plans and applies ([#686](#686)) ([797902b](797902b)) * allow subscription buffer size to be overridden ([#687](#687)) ([d51469d](d51469d)) ### Bug Fixes * avoid hitting Github limit on commit status updates ([#688](#688)) ([029e525](029e525)) * don't unnecessarily restart scheduler ([#689](#689)) ([d240965](d240965)) * make linting and tests pass ([ebc1e53](ebc1e53)) * pin version of gcp pub-sub emulator docker image ([8048e72](8048e72)) * prevent subsystem failure from stopping otfd ([e5061b0](e5061b0)) * use base58 alphabet for resource IDs ([#680](#680)) ([1e7d7a2](1e7d7a2)) ### Miscellaneous * bump go ([5663eab](5663eab)) * trigger new version of agent chart upon deploy ([#690](#690)) ([155e026](155e026)) * unarchive ([c954c36](c954c36)) * upgrade dependencies ([59eb979](59eb979)) * use forked sse lib's module path ([fc9b138](fc9b138)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#685 reports the Github limit of 1000 commit status updates being routinely hit.
This PR does too things to avoid this limit being hit:
runningabstract VCS status, for which Github has no equivalent, and is not actually used anywhere else in OTF