Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sqlsrv connection string missing port and dbname #22

Merged
merged 2 commits into from
Sep 30, 2024
Merged

Sqlsrv connection string missing port and dbname #22

merged 2 commits into from
Sep 30, 2024

Conversation

mieszkou
Copy link
Contributor

@mieszkou mieszkou commented Sep 24, 2024 •
edited
Loading

What kind of change does this PR introduce? (pls check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe below

Description

fix: sqlsrv no port from .ENV in connection string
fix: sqlsrv wrong name of variable with db name

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

Related Issue

@mieszkou mieszkou changed the title Sqlsrv Sqlsrv connection string missing port and dbname Sep 24, 2024
@mychidarko mychidarko merged commit 1c77c1f into leafsphp:next Sep 30, 2024
0 of 16 checks passed
@mychidarko
Copy link
Member

Thanks for the fix @mieszkou

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mieszkou @mychidarko