-
Notifications
You must be signed in to change notification settings - Fork 189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(cli): mud init
command
#2853
Conversation
🦋 Changeset detectedLatest commit: c8face9 The changes in this PR will be included in the next version bump. This PR includes changesets to release 23 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
mud init
command
import { writeDeploymentResult } from "../utils/writeDeploymentResult"; | ||
|
||
const verifyOptions = { | ||
configPath: { type: "string", desc: "Path to the MUD config file" }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what's the expected behavior if you already have a config?
I thought the goal of mud init
was to generate a mud config given a world address?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sounds like this is mostly just setting up the scaffolding for the init
command
either way, we should prob remove this config option since we're expecting to generate this from mud init
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point, the config will ultimately be generated as part of this!
@@ -30,4 +31,5 @@ export const commands: CommandModule<any, any>[] = [ | |||
devContracts, | |||
abiTs, | |||
verify, | |||
init, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
prob need a changeset for this (and in a future PR, can edit/expand the changeset to include new behavior)
going with a different approach for now (see #3171) |
The initial scaffolding for
mud init
, simply generatingworlds.json
, as #2847This allows projects that are extending an existing World to define what address they are interacting with. Later PR's will initialise the MUD config and ABI.