Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cli): mud init command #2853

Closed
wants to merge 6 commits into from
Closed

feat(cli): mud init command #2853

wants to merge 6 commits into from

Conversation

yonadaaa
Copy link
Contributor

@yonadaaa yonadaaa commented May 22, 2024

The initial scaffolding for mud init, simply generating worlds.json, as #2847

This allows projects that are extending an existing World to define what address they are interacting with. Later PR's will initialise the MUD config and ABI.

Copy link

changeset-bot bot commented May 22, 2024

🦋 Changeset detected

Latest commit: c8face9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 23 packages
Name Type
@latticexyz/cli Patch
mock-game-contracts Patch
@latticexyz/abi-ts Patch
@latticexyz/block-logs-stream Patch
@latticexyz/common Patch
@latticexyz/config Patch
create-mud Patch
@latticexyz/dev-tools Patch
@latticexyz/faucet Patch
@latticexyz/gas-report Patch
@latticexyz/protocol-parser Patch
@latticexyz/query Patch
@latticexyz/react Patch
@latticexyz/recs Patch
@latticexyz/schema-type Patch
solhint-config-mud Patch
solhint-plugin-mud Patch
@latticexyz/store-indexer Patch
@latticexyz/store-sync Patch
@latticexyz/store Patch
@latticexyz/utils Patch
@latticexyz/world-modules Patch
@latticexyz/world Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@yonadaaa yonadaaa changed the title feat(cli): generate worlds.json given a world address feat(cli): mud init command Jun 7, 2024
import { writeDeploymentResult } from "../utils/writeDeploymentResult";

const verifyOptions = {
configPath: { type: "string", desc: "Path to the MUD config file" },
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what's the expected behavior if you already have a config?

I thought the goal of mud init was to generate a mud config given a world address?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sounds like this is mostly just setting up the scaffolding for the init command

either way, we should prob remove this config option since we're expecting to generate this from mud init?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point, the config will ultimately be generated as part of this!

@@ -30,4 +31,5 @@ export const commands: CommandModule<any, any>[] = [
devContracts,
abiTs,
verify,
init,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

prob need a changeset for this (and in a future PR, can edit/expand the changeset to include new behavior)

@holic
Copy link
Member

holic commented Sep 11, 2024

going with a different approach for now (see #3171)

@holic holic closed this Sep 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants