Fix issue introduced in http-parser -> llhttp conversion #140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #140 +/- ##
==========================================
- Coverage 58.77% 58.65% -0.13%
==========================================
Files 4 4
Lines 570 578 +8
Branches 147 147
==========================================
+ Hits 335 339 +4
- Misses 134 138 +4
Partials 101 101 ☔ View full report in Codecov by Sentry. |
sarroutbi
reviewed
Feb 12, 2024
sarroutbi
reviewed
Feb 12, 2024
sarroutbi
requested changes
Feb 12, 2024
http_parser_execute() returns the number of parsed bytes, while llhttp_execute() returns an error code. Signed-off-by: Sergio Correia <[email protected]>
sergio-correia
force-pushed
the
llhttp
branch
from
614149a
to
e2544ac
Compare
Done, thanks for checking. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
http_parser_execute() returns the number of parsed bytes, while llhttp_execute() returns an error code.