Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to set cookie expiry time #22

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

JamesCullum
Copy link

This feature would be highly appreciated and I found that someone already wrote the code and had it reviewed: Uninett#188

Sadly it was not merged in time.

@simo5
Copy link
Member

simo5 commented Apr 28, 2020

@Slava please rebase this on top of master (do not use merge commits)

@JamesCullum
Copy link
Author

JamesCullum commented May 4, 2020

Until then, this is a workaround to make the cookie valid for one year.

<If "%{HTTP_COOKIE} =~ /mellon-cookie/">
	SetEnvIf Cookie "(^|;\ *)mellon-cookie=([^;\ ]+)" MellonToken=$$2
	SetEnvIf Host "(.+)" ENVHOST=$$1
	Header always set Set-Cookie "mellon-cookie=%{MellonToken}e; Version=1; Path=/; Domain=%{ENVHOST}e; Max-Age=31556952; HttpOnly; Secure"
</If>

@afu-dev
Copy link

afu-dev commented Aug 6, 2020

Any news about this PR? Still waiting for the rebase that's right?

I can redo the patch in a new branch if needed.

@thijskh
Copy link

thijskh commented Sep 26, 2023

@afu-dev Would be great if you could do that!

@afu-dev
Copy link

afu-dev commented Sep 26, 2023

I don't think the repository is still maintained. My comment was a few years ago 😅

If I can recall correctly, I ended up building the patch myself to use it. Then migrated to another solution.

@afu-dev
Copy link

afu-dev commented Sep 26, 2023

Oh, I guess you are maintaining it now? But like I said, haven't touched the repo for +3y, I can't remember what I did to make everything work sorry 😕

@thijskh
Copy link

thijskh commented Sep 26, 2023

The project has been and currenly is under active maintenance. However it's pretty stable and most PR's relate to new features (like this one). As maintainers we do not always have a priority to work on new features that we/our employers do not use ourselves. So it may take some time to get to feature request PR's.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants