Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[13.x] Validate key files' permissions #1789

Draft
wants to merge 2 commits into
base: 13.x
Choose a base branch
from
Draft

[13.x] Validate key files' permissions #1789

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
54c6c94
validate key permissions
hafezdivandari Sep 30, 2024
ce1541f
oauth2-server handles Windows
hafezdivandari Sep 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Passport.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ class Passport
/**
* Indicates if Passport should validate the permissions of its encryption keys.
*/
public static bool $validateKeyPermissions = false;
public static bool $validateKeyPermissions = true;

/**
* Indicates if the implicit grant type is enabled.
Expand Down
2 changes: 1 addition & 1 deletion src/PassportServiceProvider.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -254,7 +254,7 @@ protected function makeCryptKey(string $type): CryptKey
$key = 'file://'.Passport::keyPath('oauth-'.$type.'.key');
}

return new CryptKey($key, null, Passport::$validateKeyPermissions && ! windows_os());
return new CryptKey($key, null, Passport::$validateKeyPermissions);
}

/**
Expand Down