Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⚡️ Warn instead of raising the exception when ipylab is not installed #283

Merged
merged 6 commits into from
May 8, 2024

Conversation

Koncopd
Copy link
Member

@Koncopd Koncopd commented May 7, 2024

No description provided.

Copy link

github-actions bot commented May 7, 2024

@github-actions github-actions bot temporarily deployed to pull request May 7, 2024 09:18 Inactive
Copy link

codecov bot commented May 7, 2024

Codecov Report

Attention: Patch coverage is 63.88889% with 13 lines in your changes are missing coverage. Please review.

Project coverage is 88.53%. Comparing base (3f635d1) to head (1b2a639).

Files Patch % Lines
nbproject/dev/_jupyter_lab_commands.py 50.00% 7 Missing ⚠️
nbproject/dev/_jupyter_communicate.py 20.00% 4 Missing ⚠️
nbproject/__init__.py 60.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #283      +/-   ##
==========================================
- Coverage   89.35%   88.53%   -0.83%     
==========================================
  Files          24       24              
  Lines        1033     1055      +22     
==========================================
+ Hits          923      934      +11     
- Misses        110      121      +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions github-actions bot temporarily deployed to pull request May 7, 2024 10:09 Inactive
@falexwolf
Copy link
Member

Looks good to me! Have you tested in an environment in which ipylab isn't installed?

@Koncopd
Copy link
Member Author

Koncopd commented May 7, 2024

Not yet, will do.

@github-actions github-actions bot temporarily deployed to pull request May 8, 2024 11:59 Inactive
@Koncopd
Copy link
Member Author

Koncopd commented May 8, 2024

Ok, everything seems to be ok.

@Koncopd Koncopd merged commit 9d8df62 into main May 8, 2024
3 of 5 checks passed
@Koncopd Koncopd deleted the ipylab_import branch May 8, 2024 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants