Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Support auto-knitted html reports during ln.finish() #2213

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

falexwolf
Copy link
Member

@falexwolf falexwolf commented Nov 25, 2024

These auto-knitted reports come with the .nb.html suffix.

Resolves:

Considered also supporting .nb.html for the CLI but concluded that it'd be more dangerous than beneficial:

@falexwolf falexwolf changed the title ✨ Support auto-knitted html reports with .nb.html suffix during ln.fi… ✨ Support auto-knitted html reports during ln.finish() Nov 25, 2024
Copy link

codecov bot commented Nov 25, 2024

Codecov Report

Attention: Patch coverage is 87.50000% with 1 line in your changes missing coverage. Please review.

Project coverage is 92.36%. Comparing base (c54f99f) to head (0732cec).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
lamindb/_finish.py 87.50% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2213      +/-   ##
==========================================
- Coverage   92.36%   92.36%   -0.01%     
==========================================
  Files          54       54              
  Lines        6566     6572       +6     
==========================================
+ Hits         6065     6070       +5     
- Misses        501      502       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@github-actions github-actions bot temporarily deployed to pull request November 25, 2024 11:26 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant