Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove self.kwargs leftover argument #2198

Closed
wants to merge 1 commit into from
Closed

Conversation

mossjacob
Copy link

@mossjacob mossjacob commented Nov 21, 2024

Looks like self.kwargs was not removed properly in the add_new_from_columns function, calls to which were failing because of an unexpected argument.

See this blame for the cause

@falexwolf
Copy link
Member

Ping @sunnyosun! :D

@falexwolf
Copy link
Member

Ping @sunnyosun!

@sunnyosun
Copy link
Member

Sorry I somehow missed this, add_new_from_columns is now deprecated and this issue should be fixed with this refactor: #2186

Please let me know if you still run into issues :)

@sunnyosun sunnyosun closed this Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants