Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Up to php 8.3 syntax #213

Open
wants to merge 2 commits into
base: staging
Choose a base branch
from

Conversation

samsonasik
Copy link
Member

Q A
QA yes

Description

Signed-off-by: Abdul Malik Ikhsan <[email protected]>
@froschdesign
Copy link
Member

@samsonasik
Please fix all problems from the Psalm QA check.
Thanks in advance! 👍🏻

Signed-off-by: Abdul Malik Ikhsan <[email protected]>
@samsonasik
Copy link
Member Author

@froschdesign done 👍 I've fixed psalm notice 👍

@Xerkus
Copy link
Member

Xerkus commented Oct 8, 2024

There are no tests in this repository. This must me manually verified as working in deployment environment.

@alexmerlin
Copy link
Member

@arhimede Can we deploy this to confirm that everything works?

@samsonasik
Copy link
Member Author

@alexmerlin I tested locally, it seems working ok, feel free if other can test and verify in case of I missed something

@arhimede
Copy link
Member

@laminas/technical-steering-committee can we deploy this PR without tests ?
I am not sure what to do here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants